Skip to content

Conversation

@prateekj117
Copy link
Member

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

An unverified User warning is now displayed on the Create Event page as well as unverified Users are not allowed to create an event.

Fixes #2312

@prateekj117
Copy link
Member Author

prateekj117 commented Mar 26, 2019

@CosmicCoder96 @iamareebjamal Please review.

@@ -1,4 +1,9 @@
<div class="ui container">
<div class="ui stackable grid">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will unconditionally show to the user. Where's the logic here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal It's in unverified-user-message file itself.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal It's in unverified-user-message file itself.

@iamareebjamal
Copy link
Member

I think the entire div should be visible only if the message is there. @CosmicCoder96 will tell better

@prateekj117
Copy link
Member Author

@iamareebjamal That's how it was implemented in the profile page. Also, I tried, the message doesn't display when the user is verified and does not disturb the UI.

Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prateekj117 @iamareebjamal merging for now as it is indeed it mplemented like that in other places. Though, it’s not the ideal approach. Let’s refactor all of them later in a separate issue.

@prateekj117
Copy link
Member Author

prateekj117 commented Mar 28, 2019

@CosmicCoder96 Ok. Please merge.

@abhinavk96 abhinavk96 merged commit cb1fb17 into fossasia:development Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning to verify Email

3 participants