-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Display unverified user message on create event page #2391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@CosmicCoder96 @iamareebjamal Please review. |
| @@ -1,4 +1,9 @@ | |||
| <div class="ui container"> | |||
| <div class="ui stackable grid"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will unconditionally show to the user. Where's the logic here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamareebjamal It's in unverified-user-message file itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamareebjamal It's in unverified-user-message file itself.
|
I think the entire div should be visible only if the message is there. @CosmicCoder96 will tell better |
|
@iamareebjamal That's how it was implemented in the profile page. Also, I tried, the message doesn't display when the user is verified and does not disturb the UI. |
abhinavk96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prateekj117 @iamareebjamal merging for now as it is indeed it mplemented like that in other places. Though, it’s not the ideal approach. Let’s refactor all of them later in a separate issue.
|
@CosmicCoder96 Ok. Please merge. |
Checklist
developmentbranch.Short description of what this resolves:
An unverified User warning is now displayed on the Create Event page as well as unverified Users are not allowed to create an event.
Fixes #2312