-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Added currency symbol in the total amount of tickets #2379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This changes are also done in #2376, You may close it. |
|
@mariobehling Please review it |
|
@mohitm15 And i dont think we need multiple PR for just currency parser , I have taken care that i have included all the places where this issue persist 😄 |
|
@kushthedude it means this issue has been discussed 😏 |
|
Have a look at this PR . Also this PR passed the checks @mariobehling |
|
Includes #2224 |
|
@mohitm15 I think you don't understand how open source works. I already told you in #2225 that @kushthedude is already working on it. You should've asked before opening PR for an issue which is already being worked upon. |
|
Okay
…On Mon 25 Mar, 2019, 8:33 PM Shreyansh Dwivedi, ***@***.***> wrote:
@mohitm15 <https://github.com/mohitm15> I think you don't understand how
open source works. I already told you in #2225
<#2225> that
@kushthedude <https://github.com/kushthedude> is already working on it.
You should've asked before opening PR for an issue which is already being
worked upon.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2379 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ah5JcSsSkDt173joq84tqWcBYqT61m0Mks5vaOVNgaJpZM4cG8HG>
.
|
|
I was confused between #2224 and #2376 as they both dealt with same stuff
but are two different issues. I worked on #2224 and @kushthedude worked on
#2376 . So that's why confusion created.
…On Mon 25 Mar, 2019, 8:36 PM mohit maroliya, ***@***.***> wrote:
Okay
On Mon 25 Mar, 2019, 8:33 PM Shreyansh Dwivedi, ***@***.***>
wrote:
> @mohitm15 <https://github.com/mohitm15> I think you don't understand how
> open source works. I already told you in #2225
> <#2225> that
> @kushthedude <https://github.com/kushthedude> is already working on it.
> You should've asked before opening PR for an issue which is already being
> worked upon.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#2379 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/Ah5JcSsSkDt173joq84tqWcBYqT61m0Mks5vaOVNgaJpZM4cG8HG>
> .
>
|
|
Adhere to best practices, while opening PRs, thank you. |
Checklist
developmentbranch.Short description of what this resolves:
Now it displays the currency symbol for the total amount of the tickets
Changes proposed in this pull request:
-I had changed a file to resolve this issue.
-The issue was fixed as now it displays the currency symbol.
-A screenshot is also attached to give brief understanding.
Fixes #2224
After the change