Skip to content

Conversation

@mohitm15
Copy link
Contributor

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

Now it displays the currency symbol for the total amount of the tickets

Changes proposed in this pull request:

-I had changed a file to resolve this issue.
-The issue was fixed as now it displays the currency symbol.
-A screenshot is also attached to give brief understanding.

Fixes #2224

After the change

Screenshot from 2019-03-25 19-10-44

@kushthedude
Copy link
Member

kushthedude commented Mar 25, 2019

This changes are also done in #2376, You may close it.

@mohitm15
Copy link
Contributor Author

@mariobehling Please review it

@kushthedude
Copy link
Member

kushthedude commented Mar 25, 2019

@mohitm15 And i dont think we need multiple PR for just currency parser , I have taken care that i have included all the places where this issue persist 😄

@mohitm15
Copy link
Contributor Author

mohitm15 commented Mar 25, 2019

@kushthedude it means this issue has been discussed 😏
let's wait if it passes the checks

@kushthedude
Copy link
Member

This issue has been discussed and has been included in #2376 But due to other places conflicts such small places are gettin missed , Give a look to #2376 once.

@mohitm15
Copy link
Contributor Author

Have a look at this PR . Also this PR passed the checks @mariobehling

@mohitm15
Copy link
Contributor Author

Includes #2224

@kushthedude
Copy link
Member

@mohitm15 Please check the comments on #2225 , Multiple PR for similar issue should be avoided , thats what I was saying, Else your way.

@shreyanshdwivedi
Copy link
Member

@mohitm15 I think you don't understand how open source works. I already told you in #2225 that @kushthedude is already working on it. You should've asked before opening PR for an issue which is already being worked upon.

@mohitm15
Copy link
Contributor Author

mohitm15 commented Mar 25, 2019 via email

@mohitm15
Copy link
Contributor Author

mohitm15 commented Mar 25, 2019 via email

@abhinavk96 abhinavk96 closed this Mar 27, 2019
@abhinavk96
Copy link
Contributor

Adhere to best practices, while opening PRs, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Currency symbol in items total of Add Order section

4 participants