bug #29 closes , debhelper and standard version updated #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeon-zolt
approved these changes
Dec 24, 2018
pranav1698
approved these changes
Dec 24, 2018
systemlock-0.1/debian/changelog
Outdated
| @@ -1,3 +1,11 @@ | |||
| systemlock (0.1-1.1) unstable; urgency=medium | |||
There was a problem hiding this comment.
Keep the version same until we implement versioning for this repo
There was a problem hiding this comment.
means changing it to 0.1-1 right ?
There was a problem hiding this comment.
done , please check
pranav1698
approved these changes
Dec 24, 2018
Manas-kashyap
changed the title
pranav1698
suggested changes
Dec 26, 2018
Manas-kashyap
changed the title
Manas-kashyap
force-pushed
the
master
branch
from
27c17b6
to
b1139e0
Compare
pranav1698
approved these changes
Jan 3, 2019
pranav1698
suggested changes
Jan 3, 2019
systemlock-0.1/debian/changelog
Outdated
| @@ -0,0 +1,13 @@ | |||
| systemlock (0.1-1) unstable; urgency=medium | |||
There was a problem hiding this comment.
Update this file with the correct path
There was a problem hiding this comment.
Thank you so much
pranav1698
approved these changes
Jan 3, 2019
pranav1698
suggested changes
Jan 3, 2019
pranav1698
suggested changes
Jan 4, 2019
systemlock_0.1/debian/control
Outdated
| @@ -2,8 +2,8 @@ Source: systemlock | |||
| Section: x11 | |||
| Priority: extra | |||
| Maintainer: x-mario <[email protected]> | |||
| Build-Depends: debhelper (>= 8.0.0), python(>=2.6), nautilus-admin | |||
| Standards-Version: 3.9.2 | |||
| Build-Depends: debhelper (>= 11), python(>=2.6), gksu | |||
pranav1698
suggested changes
Jan 4, 2019
systemlock_0.1/debian/control
Outdated
| @@ -2,8 +2,8 @@ Source: systemlock | |||
| Section: x11 | |||
| Priority: extra | |||
| Maintainer: x-mario <[email protected]> | |||
| Build-Depends: debhelper (>= 8.0.0), python(>=2.6), nautilus-admin | |||
| Standards-Version: 3.9.2 | |||
| Build-Depends: debhelper (>= 8.0.0), python(>=2.6), gksu | |||
There was a problem hiding this comment.
Don't change nautilus-admin here, gksu will not work for the package on latest ubuntu versions their is another pr for it
systemlock_0.1/debian/changelog
Outdated
| @@ -1,8 +1,14 @@ | |||
| systemlock (0.1-1) UNRELEASED; urgency=medium | |||
| systemlock (0.1-1.1) UNRELEASED; urgency=medium | |||
There was a problem hiding this comment.
let the version be the same until we implement versioning
pranav1698
approved these changes
Jan 4, 2019
pranav1698
reviewed
Jan 9, 2019
There was a problem hiding this comment.
@meets2tarun @abishekvashok @tabesin please review and merge this pr
abishekvashok
suggested changes
Jan 30, 2019
| * standard version updated | ||
| * debhelper bumped | ||
|
|
||
| -- Manas Kashyap <[email protected]> Thu, 03 Jan 2019 21:22:42 +0530 |
pranav1698
suggested changes
Feb 7, 2019
There was a problem hiding this comment.
@Manas-kashyap can you do the changes as requested by @abishekvashok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
Checklist
I have read the Contribution & Best practices Guide and my PR follows them.
My branch is up-to-date with the Upstream master branch.
I have added necessary documentation (if appropriate)
Added breif description
Changes proposed in this pull request:
Changes in debian/control , and debian/compat for standard version to 4.3.0 (latest released on 23/12/2018) and debhelper 11
Thank you!