Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit-form-validation #970

Open
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

Aaryan-kapur
Copy link

@Aaryan-kapur Aaryan-kapur commented Dec 17, 2019

Changes proposed in this pull request

  • Fixed email validation in the contact form.
  • Fixed the form not sending any data.
  • Made sure data is sent.

please check and suggest improvements, if any!

screenshots
ss1
ss

http://pr-970-fossasia-loklaksearch.surge.sh

Closes #936

Thank You,
Aaryan-Kapur
[email protected]
(+91)-7507442555

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #970 into development will increase coverage by 0.02%.
The diff coverage is 60%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #970      +/-   ##
===============================================
+ Coverage         64.9%   64.92%   +0.02%     
===============================================
  Files              109      109              
  Lines             2701     2703       +2     
  Branches           302      303       +1     
===============================================
+ Hits              1753     1755       +2     
  Misses             865      865              
  Partials            83       83
Impacted Files Coverage Δ
...app/contact/contact-form/contact-form.component.ts 64% <40%> (ø) ⬆️
src/app/feed/info-box/info-box.component.ts 78.72% <64%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5690c07...0fc25a2. Read the comment docs.

@Aaryan-kapur
Copy link
Author

hey please check this out, @Achint08 @sk9331657

@Achint08
Copy link
Member

Achint08 commented Jan 8, 2020

I think this PR solves the validation part (which is good) but doesn't solve the whole issue as the formspree is returning 403. otherwise LGTM .

@Dishebh
Copy link
Member

Dishebh commented Jan 28, 2020

@Aaryan-kapur Pls squash your commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact Form Not wokring
3 participants