Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use UTC internally #1451

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Use UTC internally #1451

wants to merge 5 commits into from

Commits on Jul 26, 2023

  1. Use immutable DateTime 

    Ensure DateTime cannot be accidentally mutated when passed as an argument.
    @jtojnar
    jtojnar committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4959783 View commit details
    Browse the repository at this point in the history

  2. wip: Use UTC internally 

    According to https://dev.mysql.com/doc/refman/8.0/en/time-zone-support.html

> MySQL converts `TIMESTAMP` values from the current time zone to UTC for storage, and back from UTC to the current time zone for retrieval. (This does not occur for other types such as `DATETIME`.)

That is bad.

- [ ] Check that we do not use TIMESTAMP anywhere or set MySQL timezone to UTC.
- [ ] Verify that PostgreSQL includes timezone offsets when selecting datetime values with timezone.
- [ ] Check that MySQL correctly compares datetimes in db with values containing tz offset as produced by `daos\mysql\statements::datetime()`.
- [ ] Add migrations for sqlite local → UTC when `date.timezone` is not UTC.
    @jtojnar
    jtojnar committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4938212 View commit details
    Browse the repository at this point in the history

  3. fixup! wip: Use UTC internally

    @jtojnar
    jtojnar committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    aaea1ac View commit details
    Browse the repository at this point in the history

  4. fixup! wip: Use UTC internally

    @jtojnar
    jtojnar committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a351a37 View commit details
    Browse the repository at this point in the history

  5. fixup! Use immutable DateTime

    @jtojnar
    jtojnar committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d30b23a View commit details
    Browse the repository at this point in the history