2025-03 package updates #934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kmonahan Gave this a look over, the theme builds fine initially. Since you called out the React changes, I tested the build there too and I did notice an issue. |
coreylafferty
requested changes
Mar 20, 2025
Error occurred any time a TSX file was edited. Related to microsoft/TypeScript#60692. TypeScript doesn't like exports of globals, even in JS files it shouldn't be checking anyway.
|
@tomealter Looks like the issue was related to microsoft/TypeScript#60692 and the same workaround worked for me locally. Please retest and see if error is fixed on your end as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor and package updates, plus updates to @swc/cli, @storybook/addon-webpack5-compiler-swc, webpack-cli, react-refresh, react, and react-dom.
Most noteworthy update is to React and React DOM. The previously deprecated global JSX namespace has now been removed, so you definitely have to import it if you're using React with TypeScript, and the syntax for rendering a React component on a page has changed slightly. Even still, changes are pretty minor here.