Fix breaking issues introduced in #1894 #2038
Open
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
covertivy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Following my previous contribution in #1894 I changed the default behavior of the
getFilemethod of theSMBConnectionclass.Now it always uses overly permissive share access modes instead of overly restrictive ones.
This is very useful if we wish to read "locked" files (files that have active open process handles to them).
But in doing so I forgot a crucial element of impacket's exec suite.
All of them rely on receiving a
STATUS_SHARING_VIOLATIONerror in order to know when the command stops being executed remotely.This commit fixes all exec examples and modules.