[DEVOPS-5452] Support different tls for dcap-artifact-retrieval #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original `native-tls` in `dcap-artifact-retrieval` wont work in distroless container where no CA is provided by system. The solution I proposed here is to adding support for choosing `rustls` as TLS provider for `reqwest`, `rustls` will use [webpki-roots](https://crates.io/crates/webpki-roots) for default root CAs. Also the original `native-tls` becomes addictive feature but remain default.
mzohreva
reviewed
Jan 13, 2025
mzohreva
reviewed
Jan 13, 2025
|
Please update the PR description (first comment) to reflect the new changes. |
mzohreva
approved these changes
Jan 13, 2025
It should be trivial to install the needed files in the container? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Original
native-tlsindcap-artifact-retrievalwont work in distroless container where no root CA isprovided by system.
Change
The solution I proposed here is adding support for choosing
rustlsas TLS provider forreqwest,rustlswill use webpki-roots for default root CAs.rustls-tls