Allow specifying number of worker threads used to run an enclave #625
Conversation
s-arash
requested review from
mzohreva,
nshyrei,
Taowyoo,
aditijannu,
raoulstrackx and
arai-fortanix
s-arash
force-pushed
the
arash/num-worker-threads
branch
from
b9af71e to
cc998ae
Compare
|
I had been working the CI fixes here which you will face in your CI job too - #624 |
s-arash
force-pushed
the
arash/num-worker-threads
branch
from
da2817c to
cc998ae
Compare
s-arash
force-pushed
the
arash/num-worker-threads
branch
from
cc998ae to
ea171ab
Compare
s-arash
changed the title
Thanks @aditijannu. I'll rebase this PR once your PR lands. |
s-arash
force-pushed
the
arash/num-worker-threads
branch
from
ea171ab to
cbe6600
Compare
| } | ||
|
|
||
| /// Panics if you have previously called [`arg`] or [`args`]. | ||
| /// Panics if you have previously called [`arg`], [`args`], or [`num_worker_threads`]. |
There was a problem hiding this comment.
With so many parameters that aren't shared between Command and Library enclaves, does it maybe make sense to have separate builders for Command and Library enclaves? That way, each type of builder could only have the parameters that make sense for the type of enclave it builds.
There was a problem hiding this comment.
I agree. But that would be a breaking change. I think it's better to release a sem-ver compatible version with this change, and leave this kind of refactoring to a future sem-ver breaking version.
s-arash
force-pushed
the
arash/num-worker-threads
branch
from
4fd27d4 to
2fa7a24
Compare
s-arash
force-pushed
the
arash/num-worker-threads
branch
from
2fa7a24 to
4f3aef7
Compare
|
@raoulstrackx @aditijannu @Taowyoo @mzohreva @Goirad Could you take a look at this PR? We need to merge this soon. |
This change allows users of this library to specify the number of worker threads. This lets users limit the number of cores used by an enclave.
This is a backwards-compatible change.