Add implementation of AESM client for SGX #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthsane
commented
Mar 19, 2020
parthsane
force-pushed
the
pvs/sgx-aesm
branch
4 times, most recently
from
0eeeea2
to
cf9c8e5
Compare
parthsane
commented
Mar 19, 2020
jethrogb
reviewed
Mar 20, 2020
aesm-client/src/lib.rs
Outdated
| #[derive(Default, Debug, Clone)] | ||
| pub struct AesmClient { | ||
| inner: imp::AesmClient | ||
| } | ||
|
|
||
| // TODO: Find a better alternative to removing Clone and Default trait |
jethrogb
reviewed
Mar 20, 2020
parthsane
force-pushed
the
pvs/sgx-aesm
branch
2 times, most recently
from
465f139
to
3a0c541
Compare
jethrogb
reviewed
Mar 23, 2020
.travis.yml
Outdated
| @@ -55,4 +56,4 @@ matrix: | |||
| - cargo test --verbose -p sgxs | |||
| - cargo test --verbose -p sgxs-loaders | |||
| - cargo test --verbose -p sgxs-tools --features pe2sgxs --bin isgx-pe2sgx -Z package-features | |||
|
|
|||
| - cargo build --verbose -p aesm-client | |||
aesm-client/src/lib.rs
Outdated
| #[derive(Default, Debug, Clone)] | ||
| pub struct AesmClient { | ||
| inner: imp::AesmClient | ||
| } | ||
|
|
||
| // TODO: Find a better alternative to removing Clone and Default trait |
| } | ||
|
|
||
| // FIXME: remove conditional compilation after resolving https://github.com/fortanix/rust-sgx/issues/31 | ||
| #[cfg(not(target_env = "sgx"))] |
There was a problem hiding this comment.
Just do this conditional inline (as in get_quote). You can apply #[allow(unused_mut)] on the binding.
This commit allows for using the AESM client from inside the enclave Add building of aesm for SGX target on linux in CI Add tests to build aesm-client during CI for all platforms Added a common aesm_proto mod for sgx and unix
|
bors r+ |
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of AESM for SGX takes in a TcpStream for its constructor.
It omits the get_launch_token functionality