Refactor with new/updated derive macros #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `DerAnyOwned` and `DerAny<'a>` for representing Any - Add `AlgorithmIdentifierOwned`
Taowyoo
force-pushed
the
yx/derive_refactor
branch
from
166e5f1 to
25a22c1
Compare
arai-fortanix
approved these changes
Sep 18, 2023
Better comments about used ASN.1 tag types.
|
bors r=[arai-fortanix] |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Enhance macro
derive_sequenceto support optional fields.Add a new macro
derive_sequence_ofas a help to define a asn.1 sequence of same type.Add a new type
AlgorithmIdentifierOwnedto represent owned type of X.509AlgorithmIdentifieras defined in RFC 5280 Section 4.1.1.2.Refactor implementation of types in Initial support for CMPv2 & CRMF #21 by using new macros.
This PR should be merged after Initial support for CMPv2 & CRMF #21