Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the custom DateTime struct with a transparent wrapper around chrono's #2

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Replace the custom DateTime struct with a transparent wrapper around chrono's #2

merged 1 commit into from
Aug 29, 2019

Conversation

Goirad
Copy link
Member

@Goirad Goirad commented Aug 20, 2019 •
edited
Loading

Addresses Issue #1
Also updates lazy_static from 0.2 to 1 because of deprecation warnings on such an old version

@Goirad Goirad requested a review from jethrogb August 20, 2019 23:50
@Goirad Goirad force-pushed the dario/replace-custom-datetime-chrono branch from 9616d04 to 0fc8808 Compare August 20, 2019 23:58
@Goirad Goirad requested a review from jack-fortanix August 29, 2019 21:15
@jack-fortanix
Copy link

lgtm

bors r+

bors bot added a commit that referenced this pull request Aug 29, 2019
@bors @Goirad
Merge #2
d23fc1b 
2: Replace the custom DateTime struct with a transparent wrapper around chrono's r=jack-fortanix a=Goirad

Addresses [Issue #1](#1)
Also updates `lazy_static` from `0.2` to `1` because of deprecation warnings on such an old version

Co-authored-by: Dario Gonzalez <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 29, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 0fc8808 into master Aug 29, 2019
@Goirad Goirad mentioned this pull request Aug 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jethrogb jethrogb Awaiting requested review from jethrogb

@jack-fortanix jack-fortanix Awaiting requested review from jack-fortanix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Goirad @jack-fortanix