Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading and writing V1 and V2 TbsCertificate versions, in addition to V3 #16

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

Pagten
Copy link
Contributor

@Pagten Pagten commented Dec 2, 2022

No description provided.

Copy link

@janosimas janosimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.
I would be nice if someone with specific knowledge about Certificates could also review it.

@Pagten Pagten force-pushed the pieagt/add-version-to-tbs-certificate branch from 785115f to 7772f32 Compare December 2, 2022 14:23
Copy link

@arai-fortanix arai-fortanix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@Pagten
Copy link
Contributor Author

Pagten commented Dec 2, 2022

bors r=[janosimas,arai-fortanix]

@bors
Copy link
Contributor

bors bot commented Dec 2, 2022

Build succeeded:

@bors bors bot merged commit 607dc11 into master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants