Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ECDSA Sig type #11

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Add ECDSA Sig type #11

merged 1 commit into from
Jan 7, 2022

Conversation

AdrianCX
Copy link
Contributor

@AdrianCX AdrianCX commented Jan 4, 2022

No description provided.

@raoulstrackx
Copy link
Contributor

bors d+

@bors
Copy link
Contributor

bors bot commented Jan 5, 2022

✌️ AdrianCX can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

raoulstrackx
raoulstrackx reviewed Jan 7, 2022
View reviewed changes
src/types.rs
impl DerWrite for EcdsaX962<Sha256> {
fn write(&self, writer: DERWriter) {
writer.write_sequence(|writer| {
writer.next().write_oid(&oid::ecdsaWithSHA256);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference:

@raoulstrackx
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 7, 2022

Build succeeded:

@bors bors bot merged commit e5d44ed into master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raoulstrackx raoulstrackx raoulstrackx left review comments

@ssavvides ssavvides Awaiting requested review from ssavvides

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrianCX @raoulstrackx