Initial constant-time implementation of Base64 for generic & AVX2 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-fortanix
approved these changes
Jul 31, 2019
jethrogb
force-pushed
the
jb/initial
branch
2 times, most recently
from
86cbb02 to
825280b
Compare
jethrogb
commented
Apr 22, 2020
jack-fortanix
approved these changes
Apr 22, 2020
jack-fortanix
left a comment
jack-fortanix
left a comment
There was a problem hiding this comment.
Did a pass over everything, looks good to me
Member
Author
|
bors r=jack-fortanix |
Contributor
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
src/lib.rs