Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joinmarket: include the bond-calculator script #698

Merged

Conversation

seberm
Copy link
Contributor

@seberm seberm commented May 8, 2024

Closes #693

Include the bond-calculator.py script into joinmarket's CLI commands.

@seberm seberm marked this pull request as ready for review May 8, 2024 21:35
Copy link
Member

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

Thanks @seberm

Copy link
Collaborator

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d1eb977

@seberm
Copy link
Contributor Author

seberm commented May 19, 2024

I can include these changes as a part of !702 or you can merge it and I will rebase my changes. The choice is yours. Thanks!

@jonasnick jonasnick merged commit e8f8e7f into fort-nix:master May 20, 2024
5 checks passed
@jonasnick
Copy link
Member

Merged this first because it had already been approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bond-calculator.py to the JoinMarket cli tools
3 participants