Skip to content

rtl: 0.12.3 -> 0.13.0, clightning-rest: 0.7.2 -> 0.8.0#538

Merged
jonasnick merged 3 commits intofort-nix:masterfrom
erikarvstedt:rtl-0.13.0
Aug 21, 2022
Merged

rtl: 0.12.3 -> 0.13.0, clightning-rest: 0.7.2 -> 0.8.0#538
jonasnick merged 3 commits intofort-nix:masterfrom
erikarvstedt:rtl-0.13.0

Conversation

@erikarvstedt
Copy link
Copy Markdown
Collaborator

@erikarvstedt erikarvstedt commented Aug 21, 2022

Edit: Ready to merge.

- Use `fetch-node-modules` to remove the 4161 line file `node-packages.nix`
- Only use nodejs-slim as a runtime dependency
- Shrink package size by >500M by excluding certain dev-only dependencies
- Use `fetch-node-modules`
- Only use nodejs-slim as a runtime dependency
Copy link
Copy Markdown
Member

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 53dd2a1

Thanks! The fetch-node-modules approach looks good. Seems quite a bit more straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants