Conversation
|
Thanks, Pavol, lndhub seems low maintenance and a good fit for nix-bitcoin. If it supported clightning, I'd use it right away. Why do you set |
1bbfc45 to
644b632
Compare
CLN might be supported in the future, see getAlby/lndhub.go#123
Fixed in 644b6324aff2250be84c1a5d28599ec85ae43a49 |
a263052 to
edd9def
Compare
78ea328 to
875787f
Compare
|
Initial fixups to make the service run. The best way to fix this is to make |
|
I've removed all app-specific settings and replaced them with option services.lndhub-go = {
settings = {
FEE_RESERVE = true;
MAX_SEND_AMOUNT = 1000000;
};
};If you think some of these settings deserve a dedicated NixOS option, we can add them back in (maybe via a freeform module). |
|
Merged your fixups into my branch, thanks! Added bfceb1e which fixes the database name issue. |
|
Fixups. We can add a password via the secrets mechanism, but I'd really prefer a socket connection. This should be simple to add to lndhub. |
Maybe it is enough to just change the connection string to |
|
Ah, great. But manually connecting via |
|
Maybe we need to specify also the user?
|
|
No, this didn't help. Same with the equivalent |
|
I figured it out. First, this PR has to be merged: getAlby/lndhub.go#215 and then one can use the following connection string: |
|
When getAlby/lndhub.go#218 is merged, we can remove the |
Agreed! |
|
Rebased and squashed. Added fixup commits that need to wait until next release of LndHub.go is released, containing getAlby/lndhub.go#215 and getAlby/lndhub.go#218 |
|
lndhub-go 0.10.0 which contains the required fixes in getAlby/lndhub.go#215 and getAlby/lndhub.go#218 has been released and merged to nixpkgs via NixOS/nixpkgs#185649 |
|
Rebased after #537 has been merged. Removing draft status. |
0178abd to
deeb21b
Compare
|
Pulled into the PR |
applied to a03a0b79e51c7967044be09af5a2710a1e036a72 |
erikarvstedt
left a comment
There was a problem hiding this comment.
ACK 6a195f6102ede508e1555bb0cbe0d5b2aaf33764
|
Dropped 6a195f6102ede508e1555bb0cbe0d5b2aaf33764 since NixOS/nixpkgs#204769 has been merged and no longer required. Rebased ... |
LndHub.go is an accounting wrapper for the Lightning Network. It provides separate accounts for end-users and LndHub compatible API while written in Go.
upstream: https://github.com/getAlby/lndhub.go
This is a draft PR to gather feedback, also any help about how to test this is welcome!
Fixes #517