Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes signature of onMessage #15

Closed
andreialecu opened this issue Sep 1, 2021 · 0 comments · Fixed by #16
Closed

Changes signature of onMessage #15

andreialecu opened this issue Sep 1, 2021 · 0 comments · Fixed by #16

Comments

@andreialecu
Copy link
Contributor

See:

webshell/packages/webshell/src/hooks/useWebshell.ts

Line 93 in 60af580

typeof onMessage === 'function' && onMessage(nativeEvent);

I believe this should be onMessage({ nativeEvent });

With the current behavior, what seems to happen is that e.nativeEvent.data does not exist - and that's how it's supposed to work, but e.data does.
andreialecu added a commit to andreialecu/webshell that referenced this issue Sep 1, 2021
@andreialecu
fix: onMessage nativeEvent field
6ec7a20 
Fixes formidable-webview#15
@andreialecu andreialecu mentioned this issue Sep 1, 2021
Merged
@jsamr jsamr closed this as completed in #16 Sep 1, 2021
jsamr pushed a commit that referenced this issue Sep 1, 2021
@andreialecu @jsamr
fix: onMessage nativeEvent field
d89f11c 
Fixes #15
jsamr added a commit that referenced this issue Sep 1, 2021
@jsamr
test: add coverage for onMessage nativeEvent field
39e54d7 
See #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: onMessage nativeEvent field andreialecu/webshell
1 participant
@andreialecu