fix: unecessary re-renders caused by misusage of hooks deps

fix #5
formidable-webview · Feb 6, 2021 · 9b1d579 · 9b1d579
1 parent 7e2dbdf
commit 9b1d579
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/webshell/etc/webshell.api.md b/packages/webshell/etc/webshell.api.md
@@ -210,7 +210,9 @@ export const ForceResponsiveViewportFeature: FeatureClass<ForceResponsiveViewpor
 
 // @public
 export interface ForceResponsiveViewportOptions {
+    initScale?: number;
     maxScale?: number;
+    minScale?: number;
 }
 
 // @public

diff --git a/packages/webshell/src/hooks/useWebshell.ts b/packages/webshell/src/hooks/useWebshell.ts
@@ -53,11 +53,7 @@ function useWebMessageBus(
   }: WebshellInvariantProps & MinimalWebViewProps
 ) {
   const [isLoaderReady, setIsLoaderReady] = React.useState(false);
-  const domHandlers = React.useMemo(() => registry.getWebHandlers(otherProps), [
-    otherProps,
-    registry
-  ]);
-
+  const domHandlers = registry.getWebHandlers(otherProps);
   const handleOnWebMessage = React.useCallback(
     ({ nativeEvent }: NativeSyntheticEvent<WebViewMessage>) => {
       const parsedJSON = parseJSONSafe(nativeEvent.data);