Babel 7 upgrade #145
Babel 7 upgrade #145
Conversation
|
https://github.com/yahoo/babel-plugin-react-intl/blob/v2.4.0/.travis.yml#L4-L5 Babel v7 is no longer supported under Node.js v5. |
bj00rn
force-pushed
the
babel-7-upgrade
branch
from
5dbb5c5 to
e8a8949
Compare
|
@ykzts 👍 |
| @@ -155,7 +156,7 @@ function transform(filePath, options = {}, {multiplePasses = false} = {}) { | |||
| return [plugin, { | |||
| ...BASE_OPTIONS, | |||
| ...options, | |||
| }]; | |||
| }, uuidv1()]; | |||
There was a problem hiding this comment.
somewhat dirty fix, need to add random string suffix to allow plugin to run more than once
|
Two things: one is that Babel 7.0.0 (i.e. non-beta) is out. Is it worth upgrading directly to that? The other is that I'd love to see this work go through. What's the status? Is there any way that I can help it along? |
|
@tstirrat15 moved to 7.0 |
|
@ericf what are the chances of having this merged? |
| @@ -1,8 +1,6 @@ | |||
| sudo: false | |||
| language: node_js | |||
| node_js: | |||
| - 4.2 | |||
| - 5 | |||
| - 6 | |||
There was a problem hiding this comment.
I think we should have testing on v8 and v10 right now.
There was a problem hiding this comment.
seems a little out-of-scope for this, dont you think? maybe a separate PR for this?
package.json
Outdated
| @@ -10,29 +10,33 @@ | |||
| "main": "lib/index.js", | |||
| "author": "Eric Ferraiuolo <[email protected]>", | |||
| "dependencies": { | |||
| "babel-runtime": "^6.2.0", | |||
| "@babel/runtime": "7.0.0", | |||
There was a problem hiding this comment.
Why it's not semver style like ^7.0.0? any concern?
There was a problem hiding this comment.
fixed. thanks
didn't notice. i just ran babel-upgrade https://github.com/babel/babel-upgrade
There was a problem hiding this comment.
I'm ok with this. We are going to need to release this as a major version bump.
@okuryu once you approve, we can merge and release.
|
I just published |
| @@ -4,7 +4,7 @@ | |||
| * See the accompanying LICENSE file for terms. | |||
| */ | |||
|
|
|||
| import * as p from 'path'; | |||
There was a problem hiding this comment.
Issue seems to be here where upath is clearly used in library code, but not added to normal dependencies but only devDependencies.
There was a problem hiding this comment.
@serwer-WittGruppe want to test it out and open a PR with the fix?
Upgrade to Babel 7
Resolves: #146 #132 #122