Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented if expression parser #22

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ascandone
Copy link
Contributor

No description provided.

@ascandone ascandone force-pushed the experiment/guard-in-destination branch from c56c48d to 6303612 Compare November 22, 2024 17:59
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 63.27869% with 560 lines in your changes missing coverage. Please review.

Project coverage is 61.44%. Comparing base (9bf4d35) to head (5d5367f).

Files with missing lines Patch % Lines
internal/parser/antlr/numscript_parser.go 59.69% 390 Missing and 36 partials ⚠️
internal/interpreter/evaluate_expr.go 59.32% 32 Missing and 16 partials ⚠️
internal/parser/antlr/numscript_base_listener.go 0.00% 28 Missing ⚠️
internal/interpreter/overloads.go 47.05% 15 Missing and 3 partials ⚠️
internal/interpreter/interpreter.go 72.50% 8 Missing and 3 partials ⚠️
internal/interpreter/value.go 30.76% 9 Missing ⚠️
internal/parser/parser.go 75.67% 9 Missing ⚠️
internal/interpreter/batch_balances_query.go 40.00% 4 Missing and 2 partials ⚠️
internal/parser/ast.go 0.00% 3 Missing ⚠️
internal/interpreter/interpreter_error.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   63.24%   61.44%   -1.80%     
==========================================
  Files          29       29              
  Lines        6456     7486    +1030     
==========================================
+ Hits         4083     4600     +517     
- Misses       2191     2650     +459     
- Partials      182      236      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ascandone ascandone marked this pull request as draft November 23, 2024 12:07
@ascandone ascandone force-pushed the feat/add-infix-operators branch 2 times, most recently from bd4b15b to b0d00e9 Compare November 27, 2024 11:33
Base automatically changed from feat/add-infix-operators to main November 27, 2024 14:43
@ascandone ascandone force-pushed the experiment/guard-in-destination branch from 2324515 to 535a014 Compare December 6, 2024 10:57
Copy link

coderabbitai bot commented Dec 6, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ascandone ascandone force-pushed the experiment/guard-in-destination branch from 455c200 to 5d5367f Compare December 16, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant