Use Rate-limit Aware HTTP Transport #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Leveraged existing patterns/code used for the normal terraform-provider-github package which was first implimented in [this PR](integrations/terraform-provider-github#145)
alex-b-form3
force-pushed
the
alex-add-retry-http-transport
branch
from
c145931 to
2c330a6
Compare
alex-b-form3
changed the title
alex-b-form3
changed the title
* Now the required changes have been merged to main branch in go-github-utils am upgrading to latest version
markhowardform3
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This provider, whilst fully functional, currently lacks awareness of how to hand rate limiting responses from GitHub. This causes a range of issues, not just for the workspace in question, but ultimately the whole IP/host which the Terraform plan/apply is being triggered from.
This PR implements a rate-limiting-aware HTTP client, following the same pattern initially introduced in this PR for the main GitHub provider, in fact the PR just imports the HTTP client implementation directly from the other provider for full consistency.