fix: don't panic on unknown scenario name #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a scenario that was not added is called via CLI - f1 paniced:
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x104a8d114]
goroutine 1 [running]:
github.com/form3tech-oss/f1/v2/internal/run.NewActiveScenario(0x0, 0x1400020c5a0)
/Users/nikolayvladimirov/go/src/github.com/form3tech-oss/f1/internal/run/active_scenario.go:33 +0x24
github.com/form3tech-oss/f1/v2/internal/run.(*Run).Do(0x14000244000, {0x104cb02f0, 0x1400003e280}, 0x14000064020)
/Users/nikolayvladimirov/go/src/github.com/form3tech-oss/f1/internal/run/test_runner.go:121 +0x1b8
github.com/form3tech-oss/f1/v2/internal/run.Cmd.runCmdExecute.func1(0x1400020ef08, {0x1400003e370, 0x1, 0x5?})
/Users/nikolayvladimirov/go/src/github.com/form3tech-oss/f1/internal/run/run_cmd.go:158 +0x570
github.com/spf13/cobra.(*Command).execute(0x1400020ef08, {0x1400003e320, 0x5, 0x5})
/Users/nikolayvladimirov/go/pkg/mod/github.com/spf13/[email protected]/command.go:983 +0x840
github.com/spf13/cobra.(*Command).ExecuteC(0x1400020e008)
/Users/nikolayvladimirov/go/pkg/mod/github.com/spf13/[email protected]/command.go:1115 +0x344
github.com/spf13/cobra.(*Command).Execute(...)
/Users/nikolayvladimirov/go/pkg/mod/github.com/spf13/[email protected]/command.go:1039
github.com/spf13/cobra.(*Command).ExecuteContext(...)
/Users/nikolayvladimirov/go/pkg/mod/github.com/spf13/[email protected]/command.go:1032
github.com/form3tech-oss/f1/v2/pkg/f1.(*F1).execute(0x14000039e50, {0x0, 0x0, 0x0})
/Users/nikolayvladimirov/go/src/github.com/form3tech-oss/f1/pkg/f1/f1.go:106 +0x16c
github.com/form3tech-oss/f1/v2/pkg/f1.(*F1).Execute(0x14000039e50?)
/Users/nikolayvladimirov/go/src/github.com/form3tech-oss/f1/pkg/f1/f1.go:123 +0x28
main.main()
/Users/nikolayvladimirov/go/src/github.com/form3tech-oss/f1/benchcmd/main.go:9 +0x13c
```
Co-Authored-By: Liam Shepherd <[email protected]>
liam-shepherd-form3
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a scenario that was not added is called via CLI - f1 paniced: