New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: constant flag names #198

Merged

nvloff-f3 merged 1 commit into master from nvloff-flags

Apr 5, 2024

Contributor

nvloff-f3 commented Apr 5, 2024 •

edited

Loading

Extract flag names to constants to avoid possible misalignment between defining the flag and using it.
metrics: use constant name for dropped instead of string literal
rework run command flag setup to make it obvious how IgnoreCommonFlags is applied.
Verbose error when concurrency is negative instead of a generic "invalid value".
Extract distribution types to constants to avoid possible misalignment.

nvloff-f3 requested a review from a team as a code owner

April 5, 2024 04:08

nvloff-f3 force-pushed the nvloff-flags branch from 1a40254 to 62fc0cc Compare

April 5, 2024 04:10


          chore: constant flag names

28e86c6

nvloff-f3 force-pushed the nvloff-flags branch from 62fc0cc to 28e86c6 Compare

April 5, 2024 04:21

mlornac approved these changes

View reviewed changes

nvloff-f3 merged commit bb80709 into master

4 checks passed

nvloff-f3 deleted the nvloff-flags branch

April 5, 2024 07:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet