Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default case to reduce cpu consumption #131

Conversation

victorwatrelos
Copy link

When running a stage configured loadtest, the agent always take 100% of a core, as there is a spin in a select in the file internal/trigger/file/stages_worker.go .

With this MR, it only tick when there is something to do.

@victorwatrelos victorwatrelos requested a review from a team as a code owner August 16, 2023 16:13
@andykuszyk-form3 andykuszyk-form3 changed the base branch from master to victorwatrelos_fix_spin_loop_reduce_cpu August 21, 2023 08:19
@andykuszyk-form3
Copy link
Contributor

Hey @victorwatrelos 👋

Thanks for the contribution! 🙏

I'm going to merge this PR into another topic branch within the repo, so that we can run the CI on it.

@andykuszyk-form3 andykuszyk-form3 merged commit fda194f into form3tech-oss:victorwatrelos_fix_spin_loop_reduce_cpu Aug 21, 2023
@andykuszyk-form3
Copy link
Contributor

Here is the new PR: #132

The CI passes 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants