Skip to content

Conversation

@tueda
Copy link
Collaborator

@tueda tueda commented Feb 25, 2025

This patch restricts code coverage to tests checked with Valgrind by using the new --fake-valgrind option.
See also discussion in #524.

Add options to override behaviour related to Valgrind (as checked by
valgrind?). The option --fake-valgrind makes the test suite behave as if
running under Valgrind, while --fake-no-valgrind makes it behave as if
Valgrind were not present, regardless of the actual environment.
This restricts coverage to tests checked with Valgrind.
@coveralls
Copy link

Coverage Status

coverage: 49.768% (-1.0%) from 50.74%
when pulling 20b9727 on tueda:test-fake-valgrind
into 1d5e40b on vermaseren:master.

Copy link
Collaborator

@jodavies jodavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Once this is in I will get #524 in shape. The test coverage goes down for a while but hopefully we can improve this will some extra tests.

@jodavies jodavies merged commit 2e8c79c into form-dev:master May 22, 2025
70 checks passed
@tueda tueda deleted the test-fake-valgrind branch September 30, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants