Skip to content

Conversation

@tueda
Copy link
Collaborator

@tueda tueda commented Feb 8, 2025

This closes #619.

@coveralls
Copy link

coveralls commented Feb 8, 2025

Coverage Status

coverage: 49.263% (-0.03%) from 49.29%
when pulling 41966e3 on tueda:ci-build-arm64-linux
into 5e4cef5 on vermaseren:master.

@tueda tueda force-pushed the ci-build-arm64-linux branch from 179fcc9 to 2ae4458 Compare February 8, 2025 10:42
@tueda
Copy link
Collaborator Author

tueda commented Feb 8, 2025

signed charSBYTE. This clarifies the intention.

@tueda
Copy link
Collaborator Author

tueda commented Mar 5, 2025

Moving from the ubuntu-20.04 image to ubuntu-22.04 image with this patch will fail to build binaries because of the same cache hash key for the different architectures. This PR will fix this build failure. A temporary workaround would be manually adding the architecture to the cache key:

-          version: 1.0
+          version: ${{ runner.arch }}-1.0

@jodavies
Copy link
Collaborator

That PR does not seem to have much activity, perhaps working around it locally is a good way to go for now.

Use SBYTE for signed 1-byte integers to avoid issues in environments
where char defaults to unsigned, e.g., ARM64 Linux.
@tueda tueda force-pushed the ci-build-arm64-linux branch from 2ae4458 to 5d34310 Compare May 29, 2025 22:13
@tueda
Copy link
Collaborator Author

tueda commented May 29, 2025

Rebased and applied the workaround for cache-key conflicts.

@tueda tueda force-pushed the ci-build-arm64-linux branch from 5d34310 to 41966e3 Compare May 30, 2025 06:52
@tueda
Copy link
Collaborator Author

tueda commented May 30, 2025

Fixed and added a summary to see which files were generated.

@jodavies
Copy link
Collaborator

jodavies commented May 30, 2025

Looks good, ready to merge (also for 4.3)?

@tueda
Copy link
Collaborator Author

tueda commented May 30, 2025

Sure, go ahead.

@jodavies jodavies merged commit e1289ac into form-dev:master May 30, 2025
60 checks passed
@tueda tueda deleted the ci-build-arm64-linux branch September 30, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux arm64 binaries

3 participants