- 
                Notifications
    You must be signed in to change notification settings 
- Fork 148
Enhance test suite #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance test suite #587
Conversation
b14b2ef    to
    e76a83f      
    Compare
  
    | 
 Test failures are due to warnings in  | 
| Does it make sense to implement  for  | 
| Sorry, I thought I had checked for such warnings before, at least for 95b (for this one of course the test suite does not run with --without-zlib). For this one we can replace the test setup parameters with and then one still has the crash before the fix, and it runs with no buffer size warnings. For 563 we can just change  | 
e76a83f    to
    b472e84      
    Compare
  
    | Do you want to update the 95b and 563 buffer settings as part of this series, or as a separate PR? | 
| I think I can include them. But it is also fine if you want to make a separate PR and merge it before this PR. | 
| You can put it in with this, next to/merged with the commit that changes the warning pattern. | 
a35ef5b    to
    f4afb57      
    Compare
  
    - Update RuboCop configuration to align with version 1.68. - Fix all offenses, including newly detected ones due to the update. - Minor code refactoring.
Previously, the detailed output from the --stat option appeared after the test suite summary, making it harder to access the summary when the details were lengthy. This patch tries to display the --stat details before the summary, which should work with test-unit >= 3.0.9. It also tries to use the "failure" colour for failed test lines in the details.
Starting with version 5.0.0, the output header is expected to no longer print 32-bits or 64-bits. The test suite is updated to detect the wordsize using the preprocessor calculator even when the header does not provide this information.
The new pattern detects warnings printed in non-canonical forms. Close form-dev#581.
These setup parameters are suggested by @jodavies.
f4afb57    to
    b484d7b      
    Compare
  
    
This PR depends on the first commit in #511, which improves the portability of the test suite script.
It resolves #580 by updating the Ruby minimum version to 2.0.0. It also improves
--statoption (order of) output, word size detection for v5.0.0, and includes code refactoring.Hopefully, later I would like to add some resolution for #581 (warning detection) and update the usage in the README file of the test suite (
check/README.md), but this PR could be merged as-is.