Skip to content

Conversation

@tueda
Copy link
Collaborator

@tueda tueda commented Nov 22, 2024

This PR depends on the first commit in #511, which improves the portability of the test suite script.

It resolves #580 by updating the Ruby minimum version to 2.0.0. It also improves --stat option (order of) output, word size detection for v5.0.0, and includes code refactoring.

Hopefully, later I would like to add some resolution for #581 (warning detection) and update the usage in the README file of the test suite (check/README.md), but this PR could be merged as-is.

@coveralls
Copy link

coveralls commented Nov 23, 2024

Coverage Status

coverage: 50.735%. first build
when pulling b484d7b on tueda:pr-improve-test-suite-1
into 42de574 on vermaseren:master.

@tueda tueda force-pushed the pr-improve-test-suite-1 branch from b14b2ef to e76a83f Compare December 4, 2024 05:55
@tueda
Copy link
Collaborator Author

tueda commented Dec 4, 2024

Test failures are due to warnings in Issue95b and Issue563.

@tueda
Copy link
Collaborator Author

tueda commented Dec 4, 2024

Does it make sense to implement #{(ruby expression)} and write, e.g.,

#:largesize #{threaded? && ncpu == 4 ? 450025600 : threaded? && ncpu == 2 ? 300025600 : 25600}

for Issue95b?

@tueda tueda linked an issue Dec 4, 2024 that may be closed by this pull request
@jodavies
Copy link
Collaborator

jodavies commented Dec 4, 2024

Sorry, I thought I had checked for such warnings before, at least for 95b (for this one of course the test suite does not run with --without-zlib). For this one we can replace the test setup parameters with

#:filepatches       16
#:largepatches      20
#:maxtermsize      200
#:termsinsmall      16

and then one still has the crash before the fix, and it runs with no buffer size warnings.

For 563 we can just change SubTermsInSmall to 64. Probably this resize is why I settled on 65 as a good number of terms in the argument for the test anyway...

@tueda tueda force-pushed the pr-improve-test-suite-1 branch from e76a83f to b472e84 Compare December 20, 2024 07:32
@jodavies
Copy link
Collaborator

Do you want to update the 95b and 563 buffer settings as part of this series, or as a separate PR?

@tueda
Copy link
Collaborator Author

tueda commented Dec 20, 2024

I think I can include them. But it is also fine if you want to make a separate PR and merge it before this PR.

@jodavies
Copy link
Collaborator

You can put it in with this, next to/merged with the commit that changes the warning pattern.

@tueda tueda force-pushed the pr-improve-test-suite-1 branch from a35ef5b to f4afb57 Compare January 9, 2025 07:09
tueda added 7 commits January 24, 2025 21:43
- Update RuboCop configuration to align with version 1.68.
- Fix all offenses, including newly detected ones due to the update.
- Minor code refactoring.
Previously, the detailed output from the --stat option appeared after
the test suite summary, making it harder to access the summary when the
details were lengthy. This patch tries to display the --stat details
before the summary, which should work with test-unit >= 3.0.9.

It also tries to use the "failure" colour for failed test lines in the
details.
Starting with version 5.0.0, the output header is expected to no longer
print 32-bits or 64-bits. The test suite is updated to detect the
wordsize using the preprocessor calculator even when the header does not
provide this information.
The new pattern detects warnings printed in non-canonical forms.

Close form-dev#581.
These setup parameters are suggested by @jodavies.
@tueda tueda force-pushed the pr-improve-test-suite-1 branch from f4afb57 to b484d7b Compare January 24, 2025 12:43
@tueda tueda marked this pull request as ready for review January 24, 2025 12:44
@tueda tueda merged commit 1d5e40b into form-dev:master Jan 25, 2025
70 checks passed
@tueda tueda deleted the pr-improve-test-suite-1 branch February 27, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-canonical warnings ignored in test cases Test failure with Ruby 1.9

3 participants