Skip to content

Conversation

@tueda
Copy link
Collaborator

@tueda tueda commented May 13, 2024

This PR simply adds multithreaded.frm to EXTRA_DIST (but it will lead to a conflict with #517).

Alternatively, it may not be necessary to add it to the distribution. In fact, make check does not run tests in subdirectories:

  • checkpoint/checkpoint.frm
  • forcer/forcer.frm
  • multithreaded/multithreaded.frm

Unless we implement a comprehensive testing option like make check-full, these files may not be needed by users.

Consequently, we might consider removing these files from EXTRA_DIST instead.

@coveralls
Copy link

Coverage Status

coverage: 48.776% (+0.02%) from 48.759%
when pulling 3f496b9 on tueda:fix-test-forgotten-multithreaded
into e58ebd3 on vermaseren:master.

@jodavies
Copy link
Collaborator

jodavies commented Jun 7, 2025

This would anyway need to be modified when I get around to doing #524 . Probably all available test files should come with the distribution, even if they are not run by default.

@jodavies
Copy link
Collaborator

jodavies commented Jun 9, 2025

Now this is resolved by #524.

@jodavies jodavies closed this Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants