Forgotten multithreaded.frm in distribution #518
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds
multithreaded.frmtoEXTRA_DIST(but it will lead to a conflict with #517).Alternatively, it may not be necessary to add it to the distribution. In fact,
make checkdoes not run tests in subdirectories:checkpoint/checkpoint.frmforcer/forcer.frmmultithreaded/multithreaded.frmUnless we implement a comprehensive testing option like
make check-full, these files may not be needed by users.Consequently, we might consider removing these files from
EXTRA_DISTinstead.