Change EndSort type for transform statements #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vermaseren this one needs a sanity check, I am not 100% sure of the consequences of this change. |
|
I think you are right. MulArg was added later. Before this was not a problem, and apparently when MulArg was added this problem was not considered.
And of course there may be future options.
… On 10 May 2024, at 11:22, jodavies ***@***.***> wrote:
@vermaseren <https://github.com/vermaseren> this one needs a sanity check, I am not 100% sure of the consequences of this change.
—
Reply to this email directly, view it on GitHub <#516 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJPCERENQNUWK4LEOSMCVDZBSGUVAVCNFSM6AAAAABHQJJW5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUGI3DGMRRG4>.
You are receiving this because you were mentioned.
|
tueda
reviewed
May 10, 2024
Since the transform statements are sorting into the workspace, and might have to merge patches, make them use a par=1 EndSort. This commit makes this change for all transform statements, though only mularg is going to produce an explosion of terms here. This fixes form-dev#230 and causes form-dev#183 to crash with a useful error (Term too complex during normalization).
|
It is probably worth mentioning that |
|
This is ready to merge, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the transform statements are sorting into the workspace, and might have to merge patches, make them use a par=1 EndSort. This commit makes this change for all transform statements, though only mularg is going to produce an explosion of terms here.
This fixes #230 and causes #183 to crash with a useful error (Term too complex during normalization).