Skip to content

Commit

Permalink
chore: don't ignore yarn.lock
Browse files Browse the repository at this point in the history
  • Loading branch information
mshanemc committed Mar 20, 2024
1 parent 684e9e2 commit 33784c6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

# use yarn by default, so ignore npm
package-lock.json
yarn.lock

# never checkin npm config
.npmrc
Expand Down

4 comments on commit 33784c6

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 33784c6 Previous: 3c7e03c Ratio
Child logger creation 458094 ops/sec (±2.12%) 478446 ops/sec (±2.57%) 1.04
Logging a string on root logger 797808 ops/sec (±8.27%) 880302 ops/sec (±9.12%) 1.10
Logging an object on root logger 641180 ops/sec (±8.47%) 628696 ops/sec (±9.03%) 0.98
Logging an object with a message on root logger 6102 ops/sec (±214.66%) 27716 ops/sec (±183.01%) 4.54
Logging an object with a redacted prop on root logger 436492 ops/sec (±8.89%) 531365 ops/sec (±8.80%) 1.22
Logging a nested 3-level object on root logger 395672 ops/sec (±7.85%) 22953 ops/sec (±184.42%) 0.05801017003983097

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 33784c6 Previous: 3c7e03c Ratio
Logging an object with a message on root logger 6102 ops/sec (±214.66%) 27716 ops/sec (±183.01%) 4.54

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 33784c6 Previous: 3c7e03c Ratio
Child logger creation 339908 ops/sec (±2.96%) 318730 ops/sec (±0.94%) 0.94
Logging a string on root logger 831234 ops/sec (±13.50%) 769738 ops/sec (±10.11%) 0.93
Logging an object on root logger 646790 ops/sec (±8.25%) 599413 ops/sec (±6.87%) 0.93
Logging an object with a message on root logger 2949 ops/sec (±228.70%) 9420 ops/sec (±198.85%) 3.19
Logging an object with a redacted prop on root logger 477003 ops/sec (±6.99%) 404731 ops/sec (±10.09%) 0.85
Logging a nested 3-level object on root logger 339437 ops/sec (±6.25%) 301091 ops/sec (±5.72%) 0.89

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - windows-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 33784c6 Previous: 3c7e03c Ratio
Logging an object with a message on root logger 2949 ops/sec (±228.70%) 9420 ops/sec (±198.85%) 3.19

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.