Skip to content

[W-17522423] fix: retrieve ContentTypeBundle in org browser #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luciferru wants to merge 3 commits into from
Closed

[W-17522423] fix: retrieve ContentTypeBundle in org browser #6104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e9de62
fix: retrieve ContentTypeBundle in org browser
rishabhUpa Feb 19, 2025
1096558
Merge branch 'develop' into develop
luciferru Feb 19, 2025
8a93498
Merge branch 'develop' into develop
daphne-sfdc Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/salesforcedx-vscode-core/src/util/metadataDictionary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,13 @@ const DEFINITIONS: { [key: string]: MetadataInfo } = {
directory: 'experiencePropertyTypeBundles',
pathStrategy: PathStrategyFactory.createDefaultStrategy(),
extensions: [`${sep}schema.json`]
},
contenttypebundle: {
type: 'ContentTypeBundle',
suffix: 'json',
directory: 'contentTypes',
pathStrategy: PathStrategyFactory.createDefaultStrategy(),
extensions: [`${sep}schema.json`]
}
};

Expand Down
29 changes: 29 additions & 0 deletions ...esforcedx-vscode-core/test/vscode-integration/commands/util/postconditionCheckers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,35 @@ describe('Postcondition Checkers', () => {
expect(promptStub.firstCall).to.null;
});

it('Should prompt overwrite for ContentTypeBundle components that exist', async () => {
existsStub.returns(false);
const data = {
fileName: 'Test1',
outputdir: 'package/tests',
type: 'ContentTypeBundle',
suffix: 'json'
};
pathExists(true, data, '/schema.json');

await checker.check({ type: 'CONTINUE', data });

expect(promptStub.firstCall.args[0]).to.eql([data]);
});

it('Should prompt overwrite for ContentTypeBundle components that does not exist', async () => {
existsStub.returns(false);
const data = {
fileName: 'Test1',
outputdir: 'package/tests',
type: 'ContentTypeBundle',
suffix: 'json'
};

await checker.check({ type: 'CONTINUE', data });

expect(promptStub.firstCall).to.null;
});

it('Should determine a component exists if at least one of its file extensions do', async () => {
const dictionaryStub = env.stub(MetadataDictionary, 'getInfo');
dictionaryStub.returns({
Expand Down