-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Modify apex-node TestResult to account for test setup data #387
Conversation
…dx-apex into cristi/w-15923614
ApexTestRunResult type did not match fields in query add testSetupTimeInMs to raw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my commit to this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few minor adjustments. looking great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CristiCanizales thank you. One remaining item is to ensure that when the PR is merged it is doe with the feat!:
commit tag, so it triggers a major version bump.
What does this PR do?
The new API contract only requires changes to the summary section; addition of a new property, testSetupTimeInMs, and a change in meaning of testTotalTimeInMs. The major change is the new section “setup”, which is less likely to break consumers.
Modify TestResult as follows:
For each function that returns TestResult today and is producing test results in the form of TestResultRaw
What issues does this PR fix or reference?
@W-15923420@
Functionality After