feat!: use streams to refactor writeResultFiles #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-15135036@ refactor to use streams while producing results after tests are complete
…phale/W-15135036-streams # Conflicts: # src/reporters/tapReporter.ts # src/tests/testService.ts
gbockus-sf
reviewed
Mar 22, 2024
| } | ||
| ); | ||
|
|
||
| this.push('\n\n'); |
There was a problem hiding this comment.
probably a dumb q, but does this cover all OS newlines?
gbockus-sf
reviewed
Mar 22, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
peternhale
changed the title
mingxuanzhangsfdx
approved these changes
Mar 28, 2024
peternhale
added a commit
that referenced
this pull request
Apr 17, 2024
This reverts commit 9c2123d. # Conflicts: # src/streaming/codeCoverageStringifyStream.ts # src/streaming/streamingClient.ts # src/streaming/testResultStringifyStream.ts # src/tests/asyncTests.ts # test/streaming/jsonStringifyStream.test.ts
gilgourevitch
pushed a commit
to gilgourevitch/salesforcedx-apex
that referenced
this pull request
Jun 6, 2024
* chore: wip * feat: refactor results to use streams @W-15135036@ refactor to use streams while producing results after tests are complete * chore: add human report transform and stream * chore: cleanup after merging main * refactor: create narrowing functions * chore: add elapsed time decorator to streamingClient * chore: replace hardcoded newlines with os.EOL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modifies the testService.writeFiles to use streams to produce the requested output formats on disk.
This is necessary to handle very large test results that were causing string length violations when running
JSON.stringify for json results.
@W-15135036@
AC:
Should be no changes to results produced by tests.