fix: upgrade to minimum of node 18 #333
Conversation
@W-14196513@
src/execute/executeService.ts
Outdated
| @@ -13,7 +13,7 @@ import { | |||
| soapEnv, | |||
| soapBody, | |||
| soapHeader, | |||
| action | |||
| action, | |||
There was a problem hiding this comment.
Did we change the prettier/eslint behaviour for trailing commas or did they make a default change?
There was a problem hiding this comment.
@peternhale In our main extensions repo, we changed .prettierrc to have "trailingCommas": false. Since you said this is a default change in Prettier, do we want to do the manual override here as well?
| @@ -282,6 +282,7 @@ describe('Apex Test Suites', async () => { | |||
| 'TestClass1.method1,namespace.TestClass2.method1,TestClass2.method2'; | |||
|
|
|||
| const testService = new TestService(mockConnection); | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
There was a problem hiding this comment.
Is this comment meant to be info or was this a debugging line that should be removed?
There was a problem hiding this comment.
@daphne-sfdc The comment is a directive to eslint to disable the named rule for the next line.
There was a problem hiding this comment.
Code changes all look good. Behavior unchanged from before for both Mac and Windows, as expected. QE doc here: https://salesforce.quip.com/1IubA5tO9DmG
…phale/W-14196513-node-18 # Conflicts: # src/tests/syncTests.ts
What does this PR do?
What issues does this PR fix or reference?
@W-14196513@
Should be no changes in functionality