fix: guard against undefined test results

@W-15298950@
Account for a undefined ApexTestRunResult when formatting results

src/execute/executeService.ts

@@ -56,6 +56,7 @@ export class ExecuteService {
         }
       }
     }
+    throw new Error(nls.localize('authForAnonymousApexFailed'));
   }
 
   @elapsedTime()

src/i18n/i18n.ts

@@ -91,5 +91,6 @@ export const messages = {
   covIdFormatErr: 'Cannot specify code coverage with a TestRunId result',
   startHandshake: 'Attempting StreamingClient handshake',
   finishHandshake: 'Finished StreamingClient handshake',
-  subscribeStarted: 'Subscribing to ApexLog events'
+  subscribeStarted: 'Subscribing to ApexLog events',
+  authForAnonymousApexFailed: 'The authentication for execute anonymous failed'
 };

src/i18n/index.ts

@@ -10,11 +10,11 @@ import { Localization, Message } from './localization';
 
 function loadMessageBundle(): Message {
   try {
-    const layer = new Message(messages);
-    return layer;
+    return new Message(messages);
   } catch (e) {
     console.error('Cannot find messages in i18n module');
   }
+  return undefined;
 }
 
 export const nls = new Localization(loadMessageBundle());

src/streaming/streamingClient.ts

@@ -296,16 +296,16 @@ export class StreamingClient {
       value: result
     });
 
-    for (let i = 0; i < result.records.length; i++) {
-      const item = result.records[i];
-      if (
-        item.Status === ApexTestQueueItemStatus.Queued ||
-        item.Status === ApexTestQueueItemStatus.Holding ||
-        item.Status === ApexTestQueueItemStatus.Preparing ||
-        item.Status === ApexTestQueueItemStatus.Processing
-      ) {
-        return null;
-      }
+    if (
+      result.records.some(
+        (item) =>
+          item.Status === ApexTestQueueItemStatus.Queued ||
+          item.Status === ApexTestQueueItemStatus.Holding ||
+          item.Status === ApexTestQueueItemStatus.Preparing ||
+          item.Status === ApexTestQueueItemStatus.Processing
+      )
+    ) {
+      return null;
     }
     return result;
   }

src/tests/asyncTests.ts

@@ -5,11 +5,13 @@
  * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
  */
 
+'use strict';
+
 import { Connection } from '@salesforce/core';
 import { CancellationToken, Progress } from '../common';
 import { nls } from '../i18n';
 import { AsyncTestRun, StreamingClient } from '../streaming';
-import { formatStartTime, getCurrentTime } from '../utils';
+import { elapsedTime, formatStartTime, getCurrentTime } from '../utils';
 import { formatTestErrors, getAsyncDiagnostic } from './diagnosticUtil';
 import {
   ApexTestProgressValue,
@@ -20,7 +22,6 @@ import {
   ApexTestResultData,
   ApexTestResultOutcome,
   ApexTestRunResult,
-  ApexTestRunResultRecord,
   ApexTestRunResultStatus,
   AsyncTestArrayConfiguration,
   AsyncTestConfiguration,
@@ -32,7 +33,14 @@ import * as util from 'util';
 import { QUERY_RECORD_LIMIT } from './constants';
 import { CodeCoverage } from './codeCoverage';
 import { HttpRequest } from 'jsforce';
-import { elapsedTime } from '../utils/elapsedTime';
+
+const finishedStatuses = [
+  ApexTestRunResultStatus.Aborted,
+  ApexTestRunResultStatus.Failed,
+  ApexTestRunResultStatus.Completed,
+  ApexTestRunResultStatus.Passed,
+  ApexTestRunResultStatus.Skipped
+];
 
 export class AsyncTests {
   public readonly connection: Connection;
@@ -145,49 +153,34 @@ export class AsyncTests {
   public async checkRunStatus(
     testRunId: string,
     progress?: Progress<ApexTestProgressValue>
-  ): Promise<ApexTestRunResultRecord | undefined> {
+  ): Promise<ApexTestRunResult> {
     if (!isValidTestRunID(testRunId)) {
       throw new Error(nls.localize('invalidTestRunIdErr', testRunId));
     }
 
-    let testRunSummaryQuery =
-      'SELECT AsyncApexJobId, Status, ClassesCompleted, ClassesEnqueued, ';
-    testRunSummaryQuery +=
-      'MethodsEnqueued, StartTime, EndTime, TestTime, UserId ';
-    testRunSummaryQuery += `FROM ApexTestRunResult WHERE AsyncApexJobId = '${testRunId}'`;
+    const testRunSummaryQuery = `SELECT AsyncApexJobId, Status, ClassesCompleted, ClassesEnqueued, MethodsEnqueued, StartTime, EndTime, TestTime, UserId FROM ApexTestRunResult WHERE AsyncApexJobId = '${testRunId}'`;
 
     progress?.report({
       type: 'FormatTestResultProgress',
       value: 'retrievingTestRunSummary',
       message: nls.localize('retrievingTestRunSummary')
     });
 
-    const testRunSummaryResults = (await this.connection.tooling.query(
-      testRunSummaryQuery,
-      {
-        autoFetch: true
-      }
-    )) as ApexTestRunResult;
+    try {
+      const testRunSummaryResults = (await this.connection.singleRecordQuery(
+        testRunSummaryQuery,
+        {
+          tooling: true
+        }
+      )) as ApexTestRunResult;
 
-    if (testRunSummaryResults.records.length === 0) {
+      if (finishedStatuses.includes(testRunSummaryResults.Status)) {
+        return testRunSummaryResults;
+      }
+    } catch (e) {
       throw new Error(nls.localize('noTestResultSummary', testRunId));
     }
 
-    if (
-      testRunSummaryResults.records[0].Status ===
-        ApexTestRunResultStatus.Aborted ||
-      testRunSummaryResults.records[0].Status ===
-        ApexTestRunResultStatus.Failed ||
-      testRunSummaryResults.records[0].Status ===
-        ApexTestRunResultStatus.Completed ||
-      testRunSummaryResults.records[0].Status ===
-        ApexTestRunResultStatus.Passed ||
-      testRunSummaryResults.records[0].Status ===
-        ApexTestRunResultStatus.Skipped
-    ) {
-      return testRunSummaryResults.records[0];
-    }
-
     return undefined;
   }
 
@@ -196,7 +189,7 @@ export class AsyncTests {
    * @param asyncRunResult TestQueueItem and RunId for an async run
    * @param commandStartTime start time for the async test run
    * @param codeCoverage should report code coverages
-   * @param testRunSummary test run summary
+   * @param testRunSummary test run summary | undefined
    * @param progress progress reporter
    * @returns
    */
@@ -205,7 +198,7 @@ export class AsyncTests {
     asyncRunResult: AsyncTestRun,
     commandStartTime: number,
     codeCoverage = false,
-    testRunSummary: ApexTestRunResultRecord,
+    testRunSummary: ApexTestRunResult | undefined,
     progress?: Progress<ApexTestProgressValue>
   ): Promise<TestResult> {
     const coveredApexClassIdSet = new Set<string>();
@@ -215,12 +208,12 @@ export class AsyncTests {
     const { apexTestClassIdSet, testResults, globalTests } =
       await this.buildAsyncTestResults(apexTestResults);
 
-    let outcome = testRunSummary.Status;
+    let outcome = testRunSummary?.Status ?? 'Unknown';
     if (globalTests.failed > 0) {
       outcome = ApexTestRunResultStatus.Failed;
     } else if (globalTests.passed === 0) {
       outcome = ApexTestRunResultStatus.Skipped;
-    } else if (testRunSummary.Status === ApexTestRunResultStatus.Completed) {
+    } else if (testRunSummary?.Status === ApexTestRunResultStatus.Completed) {
       outcome = ApexTestRunResultStatus.Passed;
     }
 
@@ -235,15 +228,17 @@ export class AsyncTests {
         passRate: calculatePercentage(globalTests.passed, testResults.length),
         failRate: calculatePercentage(globalTests.failed, testResults.length),
         skipRate: calculatePercentage(globalTests.skipped, testResults.length),
-        testStartTime: formatStartTime(testRunSummary.StartTime, 'ISO'),
-        testExecutionTimeInMs: testRunSummary.TestTime ?? 0,
-        testTotalTimeInMs: testRunSummary.TestTime ?? 0,
+        testStartTime: testRunSummary?.StartTime
+          ? formatStartTime(testRunSummary.StartTime, 'ISO')
+          : '',
+        testExecutionTimeInMs: testRunSummary?.TestTime ?? 0,
+        testTotalTimeInMs: testRunSummary?.TestTime ?? 0,
         commandTimeInMs: getCurrentTime() - commandStartTime,
         hostname: this.connection.instanceUrl,
         orgId: this.connection.getAuthInfoFields().orgId,
         username: this.connection.getUsername(),
         testRunId: asyncRunResult.runId,
-        userId: testRunSummary.UserId
+        userId: testRunSummary?.UserId ?? 'Unknown'
       },
       tests: testResults
     };
@@ -394,6 +389,7 @@ export class AsyncTests {
   /**
    * Abort test run with test run id
    * @param testRunId
+   * @param progress
    */
   public async abortTestRun(
     testRunId: string,
@@ -430,7 +426,7 @@ export class AsyncTests {
   private getTestRunRequestAction(
     options: AsyncTestConfiguration | AsyncTestArrayConfiguration
   ): () => Promise<string> {
-    const requestTestRun = async (): Promise<string> => {
+    return async (): Promise<string> => {
       const url = `${this.connection.tooling._baseUrl()}/runTestsAsynchronous`;
       const request: HttpRequest = {
         method: 'POST',
@@ -448,6 +444,5 @@ export class AsyncTests {
         return Promise.reject(e);
       }
     };
-    return requestTestRun;
   }
 }

src/tests/testService.ts

@@ -29,7 +29,7 @@ import { AsyncTests } from './asyncTests';
 import { SyncTests } from './syncTests';
 import { formatTestErrors } from './diagnosticUtil';
 import { QueryResult } from '../utils/types';
-import { elapsedTime } from '../utils/elapsedTime';
+import { elapsedTime } from '../utils';
 
 export class TestService {
   private readonly connection: Connection;
@@ -341,11 +341,9 @@ export class TestService {
     try {
       if (tests) {
         const payload = await this.buildTestPayload(tests);
-        const classes = payload.tests?.map((testItem) => {
-          if (testItem.className) {
-            return testItem.className;
-          }
-        });
+        const classes = payload.tests
+          ?.filter((testItem) => testItem.className)
+          .map((testItem) => testItem.className);
         if (new Set(classes).size !== 1) {
           throw new Error(nls.localize('syncClassErr'));
         }

src/tests/types.ts

@@ -255,7 +255,7 @@ export const enum ApexTestRunResultStatus {
   Skipped = 'Skipped'
 }
 
-export type ApexTestRunResultRecord = {
+export type ApexTestRunResult = {
   /**
    * The parent Apex job ID for the result
    */
@@ -278,12 +278,6 @@ export type ApexTestRunResultRecord = {
   UserId: string;
 };
 
-export type ApexTestRunResult = {
-  done: boolean;
-  totalSize: number;
-  records: ApexTestRunResultRecord[];
-};
-
 export const enum ApexTestQueueItemStatus {
   Holding = 'Holding',
   Queued = 'Queued',