Skip to content

@W-17291595: [iOS] [Instrumentation] Add QR Code feature logging to track adoption #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2025
Merged

@W-17291595: [iOS] [Instrumentation] Add QR Code feature logging to track adoption #3790

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e182ba
@W-17291595: [iOS] [Instrumentation] Add QR Code feature logging to t…
JohnsonEricAtSalesforce Dec 27, 2024
ac87637
@W-17291595: [iOS] [Instrumentation] Add QR Code feature logging to t…
JohnsonEricAtSalesforce Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libs/SalesforceSDKCore/SalesforceSDKCore/Classes/UserAccount/SFUserAccountManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@
#import <SalesforceSDKCommon/SFJsonUtils.h>
#import "SFSDKOAuth2+Internal.h"

static NSString * const kSFAppFeatureQrCodeLogin = @"QR";

// Notifications
NSNotificationName SFUserAccountManagerDidChangeUserNotification = @"SFUserAccountManagerDidChangeUserNotification";
NSNotificationName SFUserAccountManagerDidChangeUserDataNotification = @"SFUserAccountManagerDidChangeUserDataNotification";
Expand Down Expand Up @@ -422,6 +424,7 @@ - (BOOL)loginWithCompletion:(SFUserAccountManagerSuccessCallbackBlock)completion
frontDoorBridgeUrl:(nullable NSURL * )frontDoorBridgeUrl
codeVerifier:(nullable NSString *)codeVerifier
{
[SFSDKAppFeatureMarkers registerAppFeature:kSFAppFeatureQrCodeLogin];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to my comment on your Android PR is there anywhere QR Code specific we could put this instead? I did a quick search and didn't find anything (and also noticed that the isQrCodeLoginEnabled property in SalesforceSDKManager is never set/used anywhere 👀).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little tricky to find since the iOS side has more layers of abstraction even before QR Code Login was introduced. It's there, though. Take a look at ac87637

return [self authenticateWithCompletion:completionBlock
failure:failureBlock
scene:scene
Expand Down
Loading