@W-17291582: [Android] [Instrumentation] Add QR Code feature logging to track adoption #2647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to track adoption
brandonpage
reviewed
Dec 31, 2024
| * Authorization Flow but is required for Web Server Authorization Flow | ||
| */ | ||
| @Suppress("MemberVisibilityCanBePrivate") | ||
| fun loginWithFrontdoorBridgeUrl( | ||
| frontdoorBridgeUrl: String, | ||
| pkceCodeVerifier: String? | ||
| ) = webviewHelper?.loginWithFrontdoorBridgeUrl(frontdoorBridgeUrl, pkceCodeVerifier) | ||
| ) { | ||
| SalesforceSDKManager.getInstance().registerUsedAppFeature(FEATURE_QR_CODE_LOGIN) |
There was a problem hiding this comment.
I think we should move this up one call to loginWithFrontdoorBridgeUrlFromQrCode so we don't miss-report QR usage if loginWithFrontdoorBridgeUrl is used for another flow.
There was a problem hiding this comment.
Good idea. Check out today's commit 🎉
…to track adoption (Move feature logging to a QR-Code named method)
brandonpage
approved these changes
Jan 3, 2025
JohnsonEricAtSalesforce
deleted the
feature/w-17291582_android-instrumentation-add-qr-code-feature-logging-to-track-adoption
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎸 Ready For Review 🥁
This one follows along with recent changes to add a feature code for Native Login in #2637.