Only send advancements to Velocity that are broadcast to the in-game chat #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: unilock <[email protected]>
Signed-off-by: unilock <[email protected]>
bvoo
approved these changes
Jan 26, 2023
fooooooooooooooo
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this prevents, for example, the "initial" advancements from being sent to Velocity, such as "Minecraft" ("The heart and story of the game") and "Adventure" ("Adventure, exploration and combat").
it also stops advancements from being sent to Velocity when the "announceAdvancements" gamerule is set to "false". this makes sense to me, but what do you think?
(also, it seems that VelocityDiscord can't handle any advancements with colons in the title or description; it prints an "index out of bounds" error.
some solutions i thought of were to either use some other (non-conforming?) character to split the parts of the plugin message, or to send each part of the message separately; that being the player's username, the advancement's title, and the advancement's description.
a datapack with such an advancement can be found here: https://modrinth.com/datapack/tc-woodcutter/version/1.0.0 )