Support advancements #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idea_get_out_of_my_way=0x1 Signed-off-by: unilock <[email protected]>
Signed-off-by: unilock <[email protected]>
Signed-off-by: unilock <[email protected]>
Signed-off-by: unilock <[email protected]>
…ngEntityEvents.ALLOW_DEATH we use getName() instead of getDisplayName() for parity with VelocityDiscord, which can only use "real names" (not e.g. nicknames) Signed-off-by: unilock <[email protected]>
we want to remove getDisplayName() (nickname) in getDeathMessage() ("nickname died because ...") in order to prefix the death message with getName() (realname) later
Signed-off-by: unilock <[email protected]>
Signed-off-by: unilock <[email protected]>
i.e. the advancement for exploring every nether biome is now sent only once, when all biomes have been explored, rather than every time a new biome was explored (thus fulfilling only *part* of the advancement) Signed-off-by: unilock <[email protected]>
|
is this ready to merge? |
|
Should be, yeah. |
unilock
commented
Dec 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works!!
Note that I changed
onEntityDeath()(previouslyonPlayerDeath()) andsendMessage()to useplayer.getName()instead ofplayer.getDisplayName(), since VelocityDiscord can only support "real names" and not e.g. nicknames.(...unless?)
EDIT: I must've broken something, because now player names are showing up as "Realname ~Nickname" :vFixed. Also switched
ALLOW_DEATHtoAFTER_DEATHto not send the (cancelled) death message when a Totem of Undying is used.Also, I made it such that advancements are bridged only when the entire advancement is granted rather than when only a criterion has been achieved - for example, the advancement granted after every Nether biome has been explored is now only mirrored to Discord once every biome has been explored, rather than every time an individual biome is explored.
Fixes #1.
Partially fixes fooooooooooooooo/VelocityDiscord#4.