correctly pass list to generator expression #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, that makes a lot more sense! |
foonathan
added a commit
to foonathan/lex
that referenced
this pull request
May 18, 2019
foonathan
added a commit
to foonathan/lex
that referenced
this pull request
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real cause to the CMP0076 warnings is that passing lists to generator expressions should be done inside quotes. Once the quotes are added the warning disappears. Note also that according to documentation "A path that begins with a generator expression is always left unmodified." so a properly written generator expression should not trigger this warning.
The code as it is now causes CMake to add absolute path INTERFACE_SOURCES to the installed library which is wrong.