Provide support for explicit operator bool #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you test it with a type that doesn't have a constexpr operator? I think it might be an issue. |
|
Thanks for pointing that out. Using a static_cast(...) seems to solve this problem (tested on GCC 7.3.1 and clang 6.0.0). And so is removing the constexpr. Is that acceptable? |
|
Just to clarify: your code still has constexpr? If it works, I'm fine with leaving at is. |
|
Yes, the updated PR still contains constexpr in explicit operator bool(). |
|
Good, I wasn't sure the PR was updated properly, I remembered issues with constexpr on the strong typedef member functions and was surprised it works. |
dvirtz
pushed a commit
to hunter-packages/type_safe
that referenced
this pull request
Feb 17, 2019
dvirtz
pushed a commit
to hunter-packages/type_safe
that referenced
this pull request
Feb 17, 2019
saraedum
pushed a commit
to saraedum/type_safe
that referenced
this pull request
Jul 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.