Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hashable base for std::hash of strong typedefs #74

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Add hashable base for std::hash of strong typedefs #74

merged 1 commit into from
Mar 23, 2018

Conversation

JohelEGP
Copy link
Contributor

Resolves #73.
Do you think the documentation is clear enough? Should I maybe add an example?

@foonathan
Copy link
Owner

Is there any hash specialization written for a strong typedefs in this library? If so you can use hashable there and point the users to it.

@JohelEGP
Copy link
Contributor Author

There isn't. Should I add one to the examples?

@foonathan
Copy link
Owner

Yeah, then just add one to the example.

@JohelEGP
Copy link
Contributor Author

How does it look?

@foonathan
Copy link
Owner

Looks good, thanks.

@foonathan foonathan merged commit a306972 into foonathan:master Mar 23, 2018
@JohelEGP JohelEGP deleted the hashable_strong_typedef_op branch March 23, 2018 19:54
@JohelEGP JohelEGP restored the hashable_strong_typedef_op branch April 5, 2018 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohelEGP @foonathan