Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GNUC macro only to check for is_trivially_copyable support #69

Merged

Conversation

Manu343726
Copy link
Contributor

Basically, don't assume builds using clang could not use the GNU stdlibc++ standard library. Found when setting up the CI build to report standardese/cppast#33 :)

Here's a type_safe_stdlibcxx_istriviallycopyable_trait branch CI build that reproduces the problem (As with cppast 33, using the geordiejones/cpp14-build-machine docker image to build cppast with Clang 5.0).

@foonathan foonathan merged commit bf83762 into foonathan:master Jan 25, 2018
@foonathan
Copy link
Owner

Yes, thank you.

@Manu343726
Copy link
Contributor Author

Maybe you could update the cppast dependency to integrate this fix? Thanks :)

@Manu343726 Manu343726 deleted the is_trivially_copyable_clang_stdlibcxx branch January 26, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants