conan.io support #30

Manu343726 · 2016-12-24T19:14:14Z

No description provided.

foonathan · 2016-12-25T10:20:04Z

Your test package stuff does not seem to work.

Also I don't like that you have to copy an example for it.

Manu343726 · 2016-12-25T10:32:41Z

Your test package stuff does not seem to work.

Yeah, I think is a bug in the cmake generator of conan. I've sent a PR to fix it conan-io/conan#801

Also I don't like that you have to copy an example for it.

I agree it is not the best way to handle this, but I can also create the example cmake target using the examples/optional.cpp file directly.

foonathan · 2016-12-25T10:33:55Z

I agree it is not the best way to handle this, but I can also create the example cmake target using the examples/optional.cpp file directly.

Yes, that would be better.

foonathan · 2017-02-16T18:07:00Z

Ping @Manu343726.

Manu343726 · 2017-02-20T21:55:18Z

It seems there's still something weird with their cmake macro to check the compiler version:conan-io/conan#1011

We have a C++ meetup in Madrid in a couple of weeks, so reaching @drodri to (finally) fix this would be easier... (I need to review this with him since I don't see something specially weird in the code they are generating nor in the code generator)

NOTE: I'm explicitly spamming him since it seems this is the only way to make him not to ignore my messages :P

foonathan · 2017-04-26T11:42:05Z

Ping?

foonathan · 2017-11-14T09:35:02Z

So, how's it going?

memsharded · 2017-11-14T10:09:40Z

.travis.yml

  - cd type_safe/

 script:
  - mkdir build/ && cd build/
  - $CMAKE -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DCMAKE_CXX_FLAGS="-Wall -Wextra -pedantic -Wno-parentheses" -DTYPE_SAFE_BUILD_TEST_EXAMPLE=ON -DTYPE_SAFE_BUILD_DOC="$BUILD_DOCS" -DTYPE_SAFE_STANDARDESE_DOWNLOAD_DIRECTORY=../standardese/ ../
  - $CMAKE --build .
  - ./test/type_safe_test
+  - cd .. && conan test_package --build=outdated && cd build


This is very outdated now, please use conan create

memsharded · 2017-11-14T10:09:58Z

README.md

@@ -2,6 +2,7 @@

 [![Build Status](https://travis-ci.org/foonathan/type_safe.svg?branch=master)](https://travis-ci.org/foonathan/type_safe)
 [![Build status](https://ci.appveyor.com/api/projects/status/aw1j2h2s52g4laen/branch/master?svg=true)](https://ci.appveyor.com/project/foonathan/type-safe/branch/master)
+[![badge](https://img.shields.io/badge/conan.io-type_safe%2F0.1-green.svg?logo=data:image/png;base64%2CiVBORw0KGgoAAAANSUhEUgAAAA4AAAAOCAMAAAAolt3jAAAA1VBMVEUAAABhlctjlstkl8tlmMtlmMxlmcxmmcxnmsxpnMxpnM1qnc1sn85voM91oM11oc1xotB2oc56pNF6pNJ2ptJ8ptJ8ptN9ptN8p9N5qNJ9p9N9p9R8qtOBqdSAqtOAqtR%2BrNSCrNJ/rdWDrNWCsNWCsNaJs9eLs9iRvNuVvdyVv9yXwd2Zwt6axN6dxt%2Bfx%2BChyeGiyuGjyuCjyuGly%2BGlzOKmzOGozuKoz%2BKqz%2BOq0OOv1OWw1OWw1eWx1eWy1uay1%2Baz1%2Baz1%2Bez2Oe02Oe12ee22ujUGwH3AAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAACxMAAAsTAQCanBgAAAAHdElNRQfgBQkREyOxFIh/AAAAiklEQVQI12NgAAMbOwY4sLZ2NtQ1coVKWNvoc/Eq8XDr2wB5Ig62ekza9vaOqpK2TpoMzOxaFtwqZua2Bm4makIM7OzMAjoaCqYuxooSUqJALjs7o4yVpbowvzSUy87KqSwmxQfnsrPISyFzWeWAXCkpMaBVIC4bmCsOdgiUKwh3JojLgAQ4ZCE0AMm2D29tZwe6AAAAAElFTkSuQmCC)](http://www.conan.io/source/type_safe/0.1/Manu343726/testing)


These badges are outdated too, now using Bintray

memsharded · 2017-11-14T10:10:26Z

conanfile.py

+    username = 'Manu343726'
+    channel = 'testing'
+    requires = 'debug_assert/1.1@Manu343726/testing'
+    exports = '*.hpp'


Use exports_sources instead

memsharded · 2017-11-14T10:10:52Z

conanfile.py

+
+class TypeSafe(ConanFile):
+    name = 'type_safe'
+    url  = 'https://foonathan.github.io/blog/2016/10/11/type-safe.html'


The URL should point to the repo containing the recipe. It is the entry point to collaborate and give feedback.

@Manu343726 Could you fix it?

memsharded · 2017-11-14T10:11:11Z

conanfile.py

+    name = 'type_safe'
+    url  = 'https://foonathan.github.io/blog/2016/10/11/type-safe.html'
+    version = '0.1'
+    username = 'Manu343726'


username and channel shouldn't be in the recipe at all

memsharded · 2017-11-14T10:12:46Z

test_package/conanfile.py

+    settings = 'os', 'compiler', 'build_type', 'arch'
+    requires = (
+        'cmake-utils/0.0.0@Manu343726/testing',
+        'type_safe/0.1@Manu343726/testing'


This requirement can be removed now, it is autoamtically injected

memsharded · 2017-11-14T10:13:14Z

test_package/conanfile.py

+
+    def build(self):
+        cmake = CMake(self.settings)
+        self.run('cmake {} {}'.format(self.conanfile_directory, cmake.command_line))


new cmake.configure() and cmake.build() methods might be more convenient.

memsharded · 2017-11-14T10:14:20Z

test_package/CMakeLists.txt

+cmake_minimum_required(VERSION 2.8)
+
+include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake)
+include(${CONAN_CMAKE-UTILS_ROOT}/conan.cmake)


This extra include of conan.cmake might be unnecessary. You might want to update to modern CMake syntax with conan_basic_setup(TARGETS)

agauniyal · 2017-11-30T19:20:24Z

I'd like to see this library in conan as well 😄

Manu343726 · 2017-12-04T14:52:41Z

pong (sorry). I would like to get into conan again in a couple of weeks, this lib being the no 1 in my list. BTW I would need your help @memsharded to get into the new jecosystem

Manu343726 · 2018-01-03T11:10:52Z

I've finally got some time to update the packages. Both type safe and debug assert packages have been updated and pushed to my artifactory repository (https://bintray.com/manu343726/conan-packages). I'm waiting for the travis CI build to see if the package test is passing.

Manu343726 · 2018-01-04T07:15:41Z

BTW the last commit allows anyone to own the package with no changes in the recipe, just upload the package using your account and repo:

conan remote add your_remote_name your_bintray_repo_url # i.e. conan remote add origin https://bintray.com/manu343726/conan-packages
conan user -p your_bintray_user_token -r your_remote_name your_user_name
conan create your_user/your_channel # this generates and tests the package in channel "your_user/your_channel"
conan upload type_safe/0.1@your_user/your_channel --all --remote your_remote_name

memsharded · 2018-01-04T08:50:37Z

If you go one step further, you can also reuse it for future versions without modifying the recipe. Remove the name & version from the recipe then use:

conan create . PkgName/version@user/channel

Manu343726 · 2018-01-04T11:49:29Z

Oh, didn't know about that. Thanks my anonymous friend.

Manu343726 · 2018-01-11T09:07:48Z

this last commit should make the travis CI build compatible with the conan 1.0 stable release.

This commit adds a conan.io package recipe using my testing channel (Manu343726/testing). The package will be manually released into my own conan repository in artifactory (https://bintray.com/manu343726/conan-packages). Note debug_assert is released there too. The package is tagged with version 0.1, until an official release of type_safe is done. The package currently depends on debug_assert 1.3, the latest release packaged. No automatic conan packaging is implemented in the CI, only a package test. Note this must be trivial (encrypting the artifactory user key in travis, using one of the travis environment variables to check if we're building a release, etc).

Conan has two remotes (bintray official, named 'conan-center', and the old conan.io repo for backwards compatibility). Since debug_assert (and type_safe itself) is hosted in my own repository, we need to tell the conan client to add a remote pointing to my repo in order to install the debug_assert dependency

The current setup confuses conan profile discovery since conan uses gcc and clang (instead of g++ and clang++) to ask for the compiler version. The solution is simply keeping both in sync.

conan 1.0 sets this arg as mandatory for the create command. This should fix your CI build.

foonathan

I don't really want to add a lot of releases for type_safe, how would that work with conan? Can people just get the latest mater?

foonathan · 2018-01-17T21:36:55Z

conanfile.py

+
+class TypeSafe(ConanFile):
+    name = 'type_safe'
+    url  = 'https://foonathan.github.io/blog/2016/10/11/type-safe.html'


@Manu343726 Could you fix it?

foonathan · 2018-01-17T21:37:45Z

conanfile.py

+    name = 'type_safe'
+    url  = 'https://foonathan.github.io/blog/2016/10/11/type-safe.html'
+    version = '0.1'
+    requires = 'debug_assert/1.3@Manu343726/testing'


I'm guessing I have to update this one everytime I release a new version and/or update debug_assert?

Manu343726 · 2018-01-18T09:49:16Z

I don't really want to add a lot of releases for type_safe, how would that work with conan? Can people just get the latest mater?

We could maintain two different channels for the package (think of channels as "upstreams"), one with fixed package releases (the "stable" channel) and another one pointing to the latest master version of type_safe ("master"?, "latest"). Neither options are a problem from the recipe perspective (it's python after all, dwtfywt), just a matter of organization.

I'm not sure if conan packaging allows packages without explicit versioning. @memsharded?
Anyway, the different versions of the latest channel could just correspond to fixes in the recipes.

@Manu343726 Could you fix it?

Of course, sorry. I will check debug_assert recipe too just in case.

I'm guessing I have to update this one everytime I release a new version and/or update debug_assert?

Right, but we could infer the dependency programmatically from your sources. If type_safe uses a fixed debug_assert tag as submodule, we could parse that version from type_safe sources and set the package version from that tag. Note you would need to release a debug_assert package with the required version first.
OTOH we could follow the "latest" channel approach above, and tell the debug_assert package to use the latest version tagged in the sources:

def get_package_version():
   return os.system("git describe --abbrev=0 --tags", cwd=???)

class DebugAssert(ConanFile):
    version = get_package_version()
...

In general, I see what you're asking for: To release new versions of type_safe & debug_assert packages automatically, taking into account users can rely on the master branch, so packages should pick the latest master sources directly. What do you think @memsharded ? How would you handle this use case? (I'm not an expert, my comments above were just suggestions that come to my mind.

IMO the right approach would be to set up a CI build for debug_assert that handles packaging (Using your own bintray account) and only runs on releases. Then add a task to the type_safe CI on master that checks for changes and pushes a new package increasing the release fix number (i.e. if the latest type_safe git tag on master was 0.1, release 0.1.0, 0.1.2, and so on, or even user the travis build number as fix; I do that at work and works very well). It's up to the package users to update their requirements.

memsharded · 2018-01-18T10:18:32Z

In many cases you just want to have packages for tagged/published versions, in this case, v0.1.

Though you can perfectly have just pkg/master@... versions too. Packages get overwritten from the latest master.

Manu343726 · 2018-01-18T13:41:22Z

@memsharded so we could tag the package as master, cool. About getting the package version from git or an environment variable, what do you think?

memsharded · 2018-01-18T13:43:54Z

You can leave the version undefined in the recipe. Then, in your CI, for example, get it from a branch convention (like release/X.Y.Z), and use:

$ conan create . Pkg/X.Y.Z@user/channel

Manu343726 · 2018-01-18T13:53:57Z

Purrrrrfect, thanks a lot

foonathan · 2018-01-25T20:35:04Z

@Manu343726 Could you just update the project URL and then I'll merge it.

Manu343726 · 2018-01-25T21:04:09Z

Sure, I was trying to find a way to automate the dependency version.

Manu343726 · 2018-01-26T10:45:11Z

Done. Note both the package version and the dependency version would require manual changes in the recipe. Also, the debug_assert dependency is pointing to my jfrog account, it's up to you to configure your own account and submit debug_assert there.

Implement support for C style comments and exclamation mark comments, i.e. /**, /*!, /// and //! are now supported. In C style comments the first star in a row is stripped but no C++ style comment markers. Fixes foonathan#30.`

Support for new comment styles - ///, //!, /**, /*! (fixes foonathan#30), as well as end-of-line comments (//<). Comment parsing and matching done by standardese, instead of libclang. Smart merging of adjacent comments. Change command parsing, now allows putting multiple commands in the same paragraph and merge documentation paragraph if needed. Add \entity to allow remote comments, i.e. documentation in comments that aren't matched. Add \file as shorthand for \entity current-file. Add \param, \tparam and \base to document (template) parameters and base classes inside the parent comment.

Manu343726 force-pushed the master branch from 8f6d5ad to 1c92d04 Compare December 24, 2016 23:11

memsharded reviewed Nov 14, 2017

View reviewed changes

Manu343726 force-pushed the master branch 4 times, most recently from fa24512 to b74c080 Compare January 3, 2018 11:04

Manu343726 force-pushed the master branch from 1dad4d4 to c2c8fdf Compare January 3, 2018 11:58

Manu343726 force-pushed the master branch from 8b092fe to ece7ab9 Compare January 11, 2018 09:14

Manu343726 added 6 commits January 11, 2018 10:07

Set Travis CI CC (c compiler) to the toolchain C compiler

3e2fdf3

The current setup confuses conan profile discovery since conan uses gcc and clang (instead of g++ and clang++) to ask for the compiler version. The solution is simply keeping both in sync.

Run conan package test on linux only

8418a4b

remove username and channel fron conan recipe

9503f6f

Add required path option to conan create

94fed60

conan 1.0 sets this arg as mandatory for the create command. This should fix your CI build.

Manu343726 force-pushed the master branch from ece7ab9 to 94fed60 Compare January 11, 2018 10:07

foonathan requested changes Jan 17, 2018

View reviewed changes

fix package URL

63a1284

foonathan approved these changes Feb 1, 2018

View reviewed changes

Merge branch 'master' into master

f6217b0

foonathan merged commit 96662e1 into foonathan:master Feb 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

conan.io support #30

conan.io support #30

Manu343726 commented Dec 24, 2016

foonathan commented Dec 25, 2016

Manu343726 commented Dec 25, 2016

foonathan commented Dec 25, 2016

foonathan commented Feb 16, 2017

Manu343726 commented Feb 20, 2017

foonathan commented Apr 26, 2017

foonathan commented Nov 14, 2017

memsharded Nov 14, 2017

memsharded Nov 14, 2017

memsharded Nov 14, 2017

memsharded Nov 14, 2017

foonathan Jan 17, 2018

memsharded Nov 14, 2017

memsharded Nov 14, 2017

memsharded Nov 14, 2017

memsharded Nov 14, 2017

agauniyal commented Nov 30, 2017

Manu343726 commented Dec 4, 2017

Manu343726 commented Jan 3, 2018

Manu343726 commented Jan 4, 2018 •

edited

Loading

memsharded commented Jan 4, 2018

Manu343726 commented Jan 4, 2018

Manu343726 commented Jan 11, 2018

foonathan left a comment

foonathan Jan 17, 2018

foonathan Jan 17, 2018

Manu343726 commented Jan 18, 2018 •

edited

Loading

memsharded commented Jan 18, 2018

Manu343726 commented Jan 18, 2018

memsharded commented Jan 18, 2018

Manu343726 commented Jan 18, 2018

foonathan commented Jan 25, 2018

Manu343726 commented Jan 25, 2018

Manu343726 commented Jan 26, 2018

conan.io support #30

conan.io support #30

Conversation

Manu343726 commented Dec 24, 2016

foonathan commented Dec 25, 2016

Manu343726 commented Dec 25, 2016

foonathan commented Dec 25, 2016

foonathan commented Feb 16, 2017

Manu343726 commented Feb 20, 2017

foonathan commented Apr 26, 2017

foonathan commented Nov 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agauniyal commented Nov 30, 2017

Manu343726 commented Dec 4, 2017

Manu343726 commented Jan 3, 2018

Manu343726 commented Jan 4, 2018 • edited Loading

memsharded commented Jan 4, 2018

Manu343726 commented Jan 4, 2018

Manu343726 commented Jan 11, 2018

foonathan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Manu343726 commented Jan 18, 2018 • edited Loading

memsharded commented Jan 18, 2018

Manu343726 commented Jan 18, 2018

memsharded commented Jan 18, 2018

Manu343726 commented Jan 18, 2018

foonathan commented Jan 25, 2018

Manu343726 commented Jan 25, 2018

Manu343726 commented Jan 26, 2018

Manu343726 commented Jan 4, 2018 •

edited

Loading

Manu343726 commented Jan 18, 2018 •

edited

Loading