Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ActiveStorage #852

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Add support for ActiveStorage #852

merged 1 commit into from
Jan 31, 2022

Conversation

paroga
Copy link
Member

@paroga paroga commented Mar 7, 2021

No description provided.

@paroga paroga requested a review from wvengen March 7, 2021 11:54
wvengen
wvengen approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@wvengen wvengen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One question: do we need to do something with docker-compose regarding the volume?

@paroga
Copy link
Member Author

paroga commented Mar 10, 2021

do we need to do something with docker-compose regarding the volume?

not with the one in this repository. it would be cleaner to configure it in the production setup (if no other storage backend will be configured), but it's not required since there is a VOLUME statement in Dockerfile a new unnamed volume should be created automatically

@wvengen
Copy link
Member

wvengen commented Mar 10, 2021

should be created automatically

Great, that's what I wanted to check.
Would you mind updating the foodcoops.net docker-compose setup as well, so that we are prepared?
Reminder: we'll need to add something about this to the release notes.

@kidhab
Copy link
Contributor

kidhab commented Jan 31, 2022

Would you mind updating the foodcoops.net docker-compose setup as well, so that we are prepared?

Is this still necessary? If not it would be nice to merge this into master.

@wvengen wvengen merged commit 19efd68 into foodcoops:master Jan 31, 2022
@paroga paroga deleted the as branch February 18, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvengen wvengen wvengen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paroga @wvengen @kidhab