Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not go in transfer playback condition when asking for category #456

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

maxenced
Copy link
Contributor

When asking for a category with some call like :

action: spotcast.start
data:
  category: 0JQ5DAqbMKFI3pNLtYMD9S
  spotify_device_id: xxxxxxxxxxxxxxxxxxxxxxx

the part of code in start_casting which check for player transfer did not check if category was empty, hence result of above call was only a transfer (if needed), but category is never changed.

@maxenced
Copy link
Contributor Author

maxenced commented Oct 1, 2024

@fcusson anything I can do to help getting this merged ?

@fcusson fcusson merged commit 31d7a11 into fondberg:master Oct 17, 2024
1 check passed
@fcusson
Copy link
Collaborator

fcusson commented Oct 17, 2024

no just needed to take the time, wanted to do multiple merge in one release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants