Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 2021.12.0 #271

Merged
merged 6 commits into from
Dec 12, 2021
Merged

Fixes for 2021.12.0 #271

merged 6 commits into from
Dec 12, 2021

Conversation

hmmbob
Copy link
Contributor

@hmmbob hmmbob commented Dec 5, 2021

2021.12.0 has a bump of pychromecast, which changes the way you can retrieve Chromecast info.

home-assistant/core#59719
home-assistant/core#60205

With the changes in this PR I fixed the issue locally. It should be tested by others too.
Also implemented a fix for a warning on device_state_attributes while I was at it anyways - this is just a rename to extra_state_attributes

Fixes #269
Fixes #273
Fixes #274
Fixes custom-cards/spotify-card#170

@Bluhme1
Copy link

Bluhme1 commented Dec 5, 2021

I have tried it, too and everything works again. Great job
Thank you

Copy link
Owner

@fondberg fondberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for lack of time. Have huge family issues.
This looks good though

@ssiergl
Copy link

ssiergl commented Dec 12, 2021

Working as expected. Thanks :)

@bjebb
Copy link

bjebb commented Dec 12, 2021

Works fine. Thanks!

@hmmbob
Copy link
Contributor Author

hmmbob commented Dec 12, 2021

@Darkfull-Dante Hi Felix, can you possibly help getting this merged and released?

@fcusson
Copy link
Collaborator

fcusson commented Dec 12, 2021

sorry for the lack of feedback on my part, I was pretty swamped in the last few days. I just tested with 2021.12.0 and everything is working fine. make bump has been made, so perfect.

I'll merge in the following hours

@fcusson fcusson merged commit 87a67c7 into fondberg:master Dec 12, 2021
@hmmbob hmmbob deleted the patch-1 branch December 12, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants