corr-252 #255
Merged
corr-252 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fondberg
approved these changes
Oct 20, 2021
|
made the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #252.
I have added the method
helpers.get_spotify_install_status()that returns True if entities linked to the Spotify platform where found and false otherwise (more specifically, it returns fall if the number of elements in the list of entities of the platform is 0[zero]).In
__init__.setup()I added a check at the starts that compares the return of the methods and if false, send an error log and returns false to the setup effectively aborting it.I did the following test:
The only test I couldn't do now was testing on a machine without the Spotify Integration, but I simulated it by pointing toward a wrongly typed platform to simulate the absence of the integration.